| Dec |
JAN |
Feb |
|
07 |
|
| 2025 |
2026 |
2027 |
About this capture
The Wayback Machine - http://web.archive.org/web/20260107115438/https://github.com/github/codeql/pull/4772
Skip to content
Navigation Menu
Appearance settings
AI CODE CREATION
GitHub CopilotWrite better code with AI
GitHub SparkBuild and deploy intelligent apps
GitHub ModelsManage and compare prompts
MCP RegistryNewIntegrate external tools
DEVELOPER WORKFLOWS
ActionsAutomate any workflow
CodespacesInstant dev environments
IssuesPlan and track work
Code ReviewManage code changes
APPLICATION SECURITY
GitHub Advanced SecurityFind and fix vulnerabilities
Code securitySecure your code as you build
Secret protectionStop leaks before they start
EXPLORE
●Why GitHub
●Documentation
●Blog
●Changelog
●Marketplace
View all features
BY COMPANY SIZE
●Enterprises
●Small and medium teams
●Startups
●Nonprofits
BY USE CASE
●App Modernization
●DevSecOps
●DevOps
●CI/CD
●View all use cases
BY INDUSTRY
●Healthcare
●Financial services
●Manufacturing
●Government
●View all industries
View all solutions
EXPLORE BY TOPIC
●AI
●Software Development
●DevOps
●Security
●View all topics
EXPLORE BY TYPE
●Customer stories
●Events & webinars
●Ebooks & reports
●Business insights
●GitHub Skills
SUPPORT & SERVICES
●Documentation
●Customer support
●Community forum
●Trust center
●Partners
COMMUNITY
GitHub SponsorsFund open source developers
PROGRAMS
●Security Lab
●Maintainer Community
●Accelerator
●Archive Program
REPOSITORIES
●Topics
●Trending
●Collections
ENTERPRISE SOLUTIONS
Enterprise platformAI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced SecurityEnterprise-grade security features
Copilot for BusinessEnterprise-grade AI features
Premium SupportEnterprise-grade 24/7 support
●Pricing
Search or jump to...
Clear
Search syntax tips
Provide feedback
Saved searches
Use saved searches to filter your results more quickly
To see all available qualifiers, see our documentation.
Appearance settings
You signed in with another tab or window. Reload to refresh your session.
You signed out in another tab or window. Reload to refresh your session.
You switched accounts on another tab or window. Reload to refresh your session.
Dismiss alert
{{ message }}
github
/
codeql
Public
●
Notifications
You must be signed in to change notification settings
●
Fork
1.9k
Star
9.1k
●
Code
●
Issues
917
●
Pull requests
372
●
Discussions
●
Actions
●
Projects
0
●
Models
●
Security
Uh oh!
There was an error while loading. Please reload this page.
●
Insights
Additional navigation options
●
Code
●
Issues
●
Pull requests
●
Discussions
●
Actions
●
Projects
●
Models
●
Security
●
Insights
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Sign up for GitHub
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
Sign in
to your account
Jump to bottom
Closed
asgerf
wants to merge
7
commits into
github:main
from
asgerf:js/source-node-tweaks
Closed
asgerf
wants to merge
7
commits into
github:main
from
asgerf:js/source-node-tweaks
Files changed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show hidden characters
Contributor
Evaluation (internal link) shows a minor slow down due to optimizer wobbles, but it has been observed to help with the BDD node limit in some cases.
Sorry, something went wrong.
asgerf
added
the
JS
label
Dec 3, 2020
max-schaefer
previously approved these changes
Dec 3, 2020
View reviewed changes
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor suggestion.
I'd be happy to accept the (apparently minor) performance penalty.
Sorry, something went wrong.
javascript/ql/src/semmle/javascript/ApiGraphs.qll
Outdated
|
|
private class NodeModuleSourcesNodes extends DataFlow::SourceNode::Range {
|
|
|
NodeModuleSourcesNodes() {
|
|
|
exists(NodeModule m |
|
|
|
this = DataFlow::ssaDefinitionNode(SSA::implicitInit([m.getModuleVariable(), m.getExportsVariable()]))
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be worth binding the variable to a field and exposing it through a getter? Then we could use that getter in the charpred of {Module,Exports}VarNode to avoid some duplication.
Sorry, something went wrong.
asgerf
dismissed
max-schaefer’s stale review
via
263a335
December 3, 2020 11:11
asgerf
marked this pull request as ready for review
December 3, 2020 11:11
asgerf
requested a review
from a team
as a code owner
December 3, 2020 11:11
max-schaefer
previously approved these changes
Dec 3, 2020
View reviewed changes
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Sorry, something went wrong.
asgerf
dismissed
max-schaefer’s stale review
via
384297d
December 3, 2020 15:05
asgerf
added 6commits
January 11, 2021 14:59
JS: Make all constant strings SourceNodes
3f9e3d2
JS: Avoid recursion in SourceNode::Range
637f28c
JS: Remove recursive def of SourceNode::Range
3209142
JS: Address review comments
1dde6e6
JS: Autoformat
e6dcc21
JS: Update benign test expectations
44b9b62
asgerf
force-pushed
the
js/source-node-tweaks
branch
from
384297dto44b9b62
Compare
January 11, 2021 15:09
JS: Update test output
87f8516
asgerf
mentioned this pull request
Jan 25, 2021
JavaScript: Teach API graphs about (some) promisification and bound arguments.
#4706
Merged
Contributor
Author
Sorry, something went wrong.
asgerf
closed this
Mar 23, 2021
asgerf
mentioned this pull request
Mar 29, 2021
JS: Make SourceNode and PropRef.getBase non-recursive, again
#5554
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers whose approvals may not affect merge requirements
No one assigned
JS
No milestone
Successfully merging this pull request may close these issues.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Footer
© 2026 GitHub, Inc.
●
Terms
●
Privacy
●
Security
●
Status
●
Community
●
Docs
●
Contact
●
●
ation
You can’t perform that action at this time.
asgerf
commented
max-schaefer
left a comment
