The Wayback Machine - http://web.archive.org/web/20210119173624/https://github.com/kripken/ammo.js/pull/320
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ava test #320

Merged
merged 19 commits into from Jul 28, 2020
Merged

feat: Ava test #320

merged 19 commits into from Jul 28, 2020

Conversation

@ianpurvis
Copy link
Collaborator

@ianpurvis ianpurvis commented Jul 27, 2020

Migrates test suite to https://github.com/avajs/ava

@ianpurvis ianpurvis force-pushed the ianpurvis:feat/ava-tests branch from 596fd3c to a4427b0 Jul 27, 2020
@ianpurvis
Copy link
Collaborator Author

@ianpurvis ianpurvis commented Jul 27, 2020

@kripken ava turned out to be a good match for the existing tests... I tried not to touch the test logic itself, but just port everything to the new runner.

One thing that I noticed was that there are some large numbers in the stress test output. I'm not sure how long it has behaved like this, or if it is even a problem. But I figured that I would mention it in case its a bug?

0 : 0.00,-56.00,0.00
1 : -4410.87,-30117726.00,251.04
2 : 6.51,-5.00,1.59
3 : 8.92,-5.61,2.37
4 : 3.95,-5.00,0.47
5 : -10667.17,-30883686.00,-4871.24
6 : 1.88,-5.61,-3.02
total time: 5.420
@kripken
Copy link
Owner

@kripken kripken commented Jul 28, 2020

Not sure if those numbers are a bug, offhand... been a long time since I read that code. IIRC it just does a simple operation but a great many times. So maybe an object really does move quite a long way on one axis.

Copy link
Owner

@kripken kripken left a comment

Nice!

@kripken kripken merged commit 320f3b2 into kripken:master Jul 28, 2020
3 checks passed
3 checks passed
build (ubuntu-latest)
Details
build (macos-latest)
Details
build (windows-latest)
Details
@ianpurvis ianpurvis deleted the ianpurvis:feat/ava-tests branch Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.