The Wayback Machine - http://web.archive.org/web/20240324171148/https://github.com/github/codeql/pull/6331
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python : Improve Xpath Injection Query #6331

Merged
merged 6 commits into from Sep 24, 2021
Merged

Python : Improve Xpath Injection Query #6331

merged 6 commits into from Sep 24, 2021

Conversation

porcupineyhairs
Copy link
Contributor

@porcupineyhairs porcupineyhairs commented Jul 19, 2021 •
edited by RasmusWL

This PR improves my earlier Xpath injection query to use APIGraphs. I can confirm that this change leads to atleast one additional detection in andresriancho/django-moth/.

@porcupineyhairs porcupineyhairs requested a review from a team as a code owner July 19, 2021 22:03

@porcupineyhairs porcupineyhairs mentioned this pull request Jul 19, 2021

Closed
@RasmusWL RasmusWL self-assigned this Sep 20, 2021
RasmusWL
RasmusWL approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@RasmusWL RasmusWL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for rewriting this modeling to use API graphs instead 💪 🎉

I added a few commits to replace the old query with the new one, and fixed a minor typo.

@RasmusWL RasmusWL merged commit 547cbb6 into github:main Sep 24, 2021
@porcupineyhairs porcupineyhairs deleted the pythonXpath branch November 21, 2021 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RasmusWL RasmusWL RasmusWL approved these changes

Assignees

@RasmusWL RasmusWL

Labels
documentation Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@porcupineyhairs @RasmusWL