The Wayback Machine - http://web.archive.org/web/20260111054328/https://github.com/github/codeql/pull/6345
Skip to content

Conversation

@tausbn
Copy link
Contributor

@tausbn tausbn commented Jul 21, 2021

... in a local scope. Or rather, remove these from the hasLocalSource
relation.

This prevents a quadratic blowup when the same global is mentioned
a lot of times within a single function scope.

... in a local scope. Or rather, remove these from the `hasLocalSource`
relation.

This prevents a quadratic blowup when the same global is mentioned
_a lot_ of times within a single function scope.
@tausbn tausbn requested a review from a team as a code owner July 21, 2021 19:03
@tausbn tausbn added the no-change-note-required This PR does not need a change note label Jul 21, 2021
@tausbn
Copy link
Contributor Author

tausbn commented Jul 22, 2021

Performance results (also check the comment I added on that issue): https://github.com/dsp-testing/tausbn-dca/issues/51

Copy link
Member

@RasmusWL RasmusWL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@tausbn
Copy link
Contributor Author

tausbn commented Sep 2, 2021

Superceded by #6351.

@tausbn tausbn closed this Sep 2, 2021
@tausbn tausbn deleted the python-limit-global-flow-for-localsourcenode branch September 2, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-change-note-required This PR does not need a change note Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants