solidity

🎉 Description

The ECDSA contract has a function toEthSignedMessage(bytes32), but we should have a function that works for any length of a bytes array:

function toEthSignedMessage(bytes s) pure internal returns (bytes32) {
  return keccak256(
    "\x19Ethereum Signed Message:\n",
    uintToBytes(s.length),
    s);
}

Where uintToBytes is implemented from an ideally

This came up in ethereum/solidity#11738 (comment)

When the cmdlineTests.sh script gets no output from the compiler, it accepts both an empty output file as well as the file not being there at all. Same with stderr and the err file. In case of exit file, it not being present is e

In this error message:

Error: There was a timeout while attempting to connect to the network.
       Check to see that your provider is valid.
       If you have a slow internet connection, try configuring a longer timeout in your Truffle config. Use the networks[networ

Description
Add a contract similar to Aave's AddressProvider or Uniswap's getPair() functionality.

Motivation
On-chain lookups of price oracles given the asset addresses.

Justification
String manipulation is difficult and expensive in Solidity, and you usually work with the token address, not its string name.

Testing methods like evm_mine and evm_increaseTime expect integer parameters. Unlike other methods, they reject these parameters if they are not decimal-encoded.

To reproduce

npx hardhat --version -> 2.5.0

Run npx hardhat node and make the following rpc calls:

> curl -H "Content-Type: application/json" -X POST --data \
        '{"id":1337,"jsonrpc":"2.0","method":"evm

From @Arachnid recent tweet, it looks like there is not good up to date solution to generate doc from natspec. We should explore the current solutions and create something on top of slither

Overview

Currently when I run brownie console, it recompiles all the contracts. Apparently due to some issue which is not identified.

I only want to compile once with brownie compile -all. That's it.
I work on the frontend side, I don't modify the contracts, I just need a local fork and run some scripts.

Currently it's slow as hell

We can safely disallow any use of solc below 0.4.25.

I left a review and then got this message

which seems strange as it's telling me something I know.