The Wayback Machine - http://web.archive.org/web/20211021110150/https://github.com/facebook/react/pull/22140
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Scheduler] Add tests for isInputPending #22140

Merged
merged 1 commit into from Aug 20, 2021
Merged

[Scheduler] Add tests for isInputPending #22140

merged 1 commit into from Aug 20, 2021

Conversation

@acdlite
Copy link
Member

@acdlite acdlite commented Aug 19, 2021

This feature was already implemented but we didn't have any tests. So I wrote some.
@acdlite acdlite requested a review from bvaughn Aug 19, 2021
@acdlite acdlite requested a review from rickhanlonii Aug 19, 2021
@sizebot
Copy link

@sizebot sizebot commented Aug 19, 2021 •
edited

Comparing: d54be90...2550a00

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 127.58 kB 127.58 kB = 40.72 kB 40.72 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 130.40 kB 130.40 kB = 41.65 kB 41.65 kB
facebook-www/ReactDOM-prod.classic.js = 405.16 kB 405.16 kB = 75.04 kB 75.04 kB
facebook-www/ReactDOM-prod.modern.js = 393.72 kB 393.72 kB = 73.32 kB 73.32 kB
facebook-www/ReactDOMForked-prod.classic.js = 405.16 kB 405.16 kB = 75.05 kB 75.05 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 2550a00

@acdlite
[Scheduler] Add tests for isInputPending
2550a00 
This feature was already implemented but we didn't have any tests. So
I wrote some.
@acdlite acdlite force-pushed the test-is-input-pending branch from 18b43cc to 2550a00 Aug 20, 2021
@acdlite acdlite merged commit 986d0e6 into facebook:main Aug 20, 2021
1 of 3 checks passed
facebook-github-bot added a commit to facebook/react-native that referenced this issue Aug 24, 2021
@kacieb @facebook-github-bot
React Native sync for revisions 424fe58...bd5bf55
7299cb4 
Summary:
Post: https://fb.workplace.com/groups/rnsyncsquad/permalink/879923262900946/

This sync includes the following changes:
- **[fc3b6a411](facebook/react@fc3b6a4 )**: Fix a few typos ([#22154](facebook/react#22154)) //<Bowen>//
- **[986d0e61d](facebook/react@986d0e6 )**: [Scheduler] Add tests for isInputPending ([#22140](facebook/react#22140)) //<Andrew Clark>//
- **[d54be90be](facebook/react@d54be90 )**: Set up test infra for dynamic Scheduler flags ([#22139](facebook/react#22139)) //<Andrew Clark>//
- **[7ed0706d7](facebook/react@7ed0706 )**: Remove the warning for setState on unmounted components ([#22114](facebook/react#22114)) //<Dan Abramov>//
- **[9eb2aaaf8](facebook/react@9eb2aaa )**: Fixed ReactSharedInternals export in UMD bundle ([#22117](facebook/react#22117)) //<Brian Vaughn>//
- **[bd255700d](facebook/react@bd25570 )**: Show a soft error when a text string or number is supplied as a child to non text wrappers ([#22109](facebook/react#22109)) //<Sota>//

Changelog:
[General][Changed] - React Native sync for revisions 424fe58...bd5bf55

jest_e2e[run_all_tests]

Reviewed By: yungsters

Differential Revision: D30485521

fbshipit-source-id: c5b92356e9e666eae94536ed31b8de43536419f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickhanlonii rickhanlonii

@bvaughn bvaughn

Assignees
No one assigned
Labels
CLA Signed React Core Team
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@acdlite @sizebot @rickhanlonii @facebook-github-bot