The Wayback Machine - http://web.archive.org/web/20210725181715/https://github.com/sdras/night-owl-vscode-theme/issues/217
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Custom Props (css variables) syntax highlighting #217

Open

chiangs opened this issue Jul 3, 2019 · 6 comments
Open

CSS Custom Props (css variables) syntax highlighting #217

chiangs opened this issue Jul 3, 2019 · 6 comments

Comments

@chiangs
Copy link

@chiangs chiangs commented Jul 3, 2019

I would like to request a little more distinction in the syntax highlighting for css variables.
code

@sdras
Copy link
Owner

@sdras sdras commented Sep 16, 2019

Definitely! This should be more legible. I'm happy to work on this but I'm low on time, so if I do it, it won't be for a couple of months. Open to PRs.

@chiangs
Copy link
Author

@chiangs chiangs commented Sep 25, 2019

I've been searching for a good reference on how to select these in the settings, but I am struggling to figure it out using TextMates' documentation. Can you share the source you referenced in building this theme? Thanks!

@chiangs
Copy link
Author

@chiangs chiangs commented Oct 2, 2019

@sdras I've got it working now, here is the regular dark theme, can you comment before i move on to the other themes?

I've opted for the purple color you used and also set it to italic when actually being used and non-italic when just being declared.

Also could you tag this as assigned to me and in progress?

code

here's another color option

code

@Arnau-Ninerola
Copy link

@Arnau-Ninerola Arnau-Ninerola commented Oct 4, 2019

@chiangs That looks really good, maybe I like the second option more. Are you working on fixing this issue? If not I would't mind taking a look.

@chiangs
Copy link
Author

@chiangs chiangs commented Oct 4, 2019

@Arnau-Ninerola Yes I am actively working on it, I just wanted @sdras to have a look first and assign to me. I think I like the second one better as well.

@chiangs
Copy link
Author

@chiangs chiangs commented Oct 7, 2019

@sdras PR opened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants