RPCs that return detailed information about mempool entries (e.g. getmempoolentry and getrawmempool(verbose=True) include the fields fee, modifiedfee, descendantfees, and ancestorfees which were marked as "DEPRECATED" and replaced with a fees object field in #12240 (since v0.17).

We should remove these fields, but first, properly deprecate them using -deprecatedrpc.

Usef

Hello spoooopyyy hackers 🎃

This is a Hacktoberfest only issue! 👻

This is also data-sciency!

The Problem

Our English dictionary contains words that aren't English, and does not contain common English words.

Examples of non-common words in the dictionary:

"hlithskjalf",
  "hlorrithi",
  "hlqn",
  "hm",
  "hny",
  "ho",
  "hoactzin",
  "hoactzine

Background

Macaroons are created after wallet creation. However, the documentation in the main installation (https://github.com/lightningnetwork/lnd/blob/master/docs/INSTALL.md) states the following:

Running lnd for the first time will by default generate the admin.macaroon, read_only.macaroon, and macaroons.db files that are used to authenticate into lnd.

As a first-time LND user,

Currently stratumserver has no unit tests. This will improve the quality and allow future commits to be TDD safe. All units will be tested to ensure the module as a unit itself is tested.

Problem:

A common pattern is:

GUARD(s2n_stuffer_skip_write(stuffer, bytes_to_write));
uint8_t* ptr = suffer->blob.data + stuffer->write_cursor - bytes_to_write;

which could be simplified.

Solution:

*ptr could be an *out parameter to s2n_stuffer_skip_write

• Does this change what S2N sends over the wire? No.
• Does this change any public APIs? No.

Issue Description

Per https://blog.ripplex.io/sunsetting-ripplex-io/, the ripplex.io site is being sunset. There are several references to it (and its predecessor xpring.io) in the rippled documentation that need to be updated.

As of 1.8.0-b3:

$ grep -ri -e xpring.io -e ripplex.io
RELEASENOTES.md:This release [significantly improves memory usage](https://blog.ripplex.io/how-ripples

As I was running composer to install a new library into our repo, it warned me that:

Package yzalis/identicon is abandoned, you should avoid using it. No replacement was suggested.

I'm not familiar on what packagist.org's process is to declare a package abandoned. I see that the last commit in their repo is from 2019 and there are a number of unanswered issues and pull requests.

I