The Wayback Machine - http://web.archive.org/web/20211003213456/https://github.com/github/codeql/pull/6797
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Remove overwritten NestedType.isStatic() QLDoc #6797

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

@Marcono1234
Copy link
Contributor

@Marcono1234 Marcono1234 commented Oct 2, 2021

The previous QLDoc did not mention nested non-member interfaces and record classes, see also #5473.

The documentation of the overridden isStatic() predicate already mentions that this predicate holds for explicitly and implicitly static elements, so overwriting it is not necessary and only adds more maintenance work.

(This pull request also includes a formatting fix for the new code I added in #6645)

Marcono1234 added 2 commits Oct 2, 2021
Did not mention nested non-member interfaces and record classes.
The documentation of the overridden `isStatic()` predicate already mentions
that this predicate holds for explicitly and implicitly static elements, so
overwriting it is not necessary and only adds more maintenance work.
@Marcono1234 Marcono1234 requested a review from as a code owner Oct 2, 2021
@github-actions github-actions bot added the Java label Oct 2, 2021
@Marcono1234 Marcono1234 changed the title Remove overwritten NestedType.isStatic() QLDoc Java: Remove overwritten NestedType.isStatic() QLDoc Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant