Dec
JAN
Feb
11
2023
2024
2025
About this capture
T h e W a y b a c k M a c h i n e - h t t p : / / w e b . a r c h i v e . o r g / w e b / 2 0 2 4 0 1 1 1 2 2 0 4 0 5 / h t t p s : / / g i t h u b . c o m / g i t h u b / c o d e q l / p u l l / 6 6 7 8
S k i p t o c o n t e n t
S i g n i n
●
A c t i o n s
A u t o m a t e a n y w o r k f l o w
P a c k a g e s
H o s t a n d m a n a g e p a c k a g e s
S e c u r i t y
F i n d a n d f i x v u l n e r a b i l i t i e s
C o d e s p a c e s
I n s t a n t d e v e n v i r o n m e n t s
C o p i l o t
W r i t e b e t t e r c o d e w i t h A I
C o d e r e v i e w
M a n a g e c o d e c h a n g e s
I s s u e s
P l a n a n d t r a c k w o r k
D i s c u s s i o n s
C o l l a b o r a t e o u t s i d e o f c o d e
E x p l o r e ●
●
●
●
●
F o r ●
●
●
●
B y S o l u t i o n ●
●
●
R e s o u r c e s ●
●
●
●
●
G i t H u b S p o n s o r s
F u n d o p e n s o u r c e d e v e l o p e r s
T h e R e a d M E P r o j e c t
G i t H u b c o m m u n i t y a r t i c l e s
R e p o s i t o r i e s ●
●
●
●
" >
S e a r c h o r j u m p t o . . .
Clear
S e a r c h s y n t a x t i p s
P r o v i d e f e e d b a c k
Include my email address so I can be contacted
C a n c e l
S u b m i t f e e d b a c k
S a v e d s e a r c h e s
U s e s a v e d s e a r c h e s t o f i l t e r y o u r r e s u l t s m o r e q u i c k l y
Query
To see all available qualifiers, see our documentation .
C a n c e l
C r e a t e s a v e d s e a r c h
Y o u s i g n e d i n w i t h a n o t h e r t a b o r w i n d o w . R e l o a d t o r e f r e s h y o u r s e s s i o n . Y o u s i g n e d o u t i n a n o t h e r t a b o r w i n d o w . R e l o a d t o r e f r e s h y o u r s e s s i o n . Y o u s w i t c h e d a c c o u n t s o n a n o t h e r t a b o r w i n d o w . R e l o a d t o r e f r e s h y o u r s e s s i o n .
D i s m i s s a l e r t
{ { m e s s a g e } }
g i t h u b
/
c o d e q l
P u b l i c
●
N o t i f i c a t i o n s
●
F o r k
1 . 6 k
S t a r
6 . 7 k
●
C o d e ●
I s s u e s 6 9 9
●
P u l l r e q u e s t s 3 1 8
●
D i s c u s s i o n s ●
A c t i o n s ●
P r o j e c t s 0
●
S e c u r i t y ●
I n s i g h t s
A d d i t i o n a l n a v i g a t i o n o p t i o n s ●
C o d e
●
I s s u e s
●
P u l l r e q u e s t s
●
D i s c u s s i o n s
●
A c t i o n s
●
P r o j e c t s
●
S e c u r i t y
●
I n s i g h t s
N e w i s s u e
H a v e a q u e s t i o n a b o u t t h i s p r o j e c t ? S i g n u p f o r a f r e e G i t H u b a c c o u n t t o o p e n a n i s s u e a n d c o n t a c t i t s m a i n t a i n e r s a n d t h e c o m m u n i t y .
Email Address
Password
Sign up for GitHub
B y c l i c k i n g “ S i g n u p f o r G i t H u b ” , y o u a g r e e t o o u r t e r m s o f s e r v i c e a n d
p r i v a c y s t a t e m e n t . W e ’ l l o c c a s i o n a l l y s e n d y o u a c c o u n t r e l a t e d e m a i l s .
A l r e a d y o n G i t H u b ?
S i g n i n t o y o u r a c c o u n t
J u m p t o b o t t o m
M e r g e d
j b j m e r g e d 4 c o m m i t s i n t o
g i t h u b : m a i n f r o m
a n d e r s f u g m a n n : r e f a c t o r _ u s e _ o f _ i s G u a r d P h i
S e p 2 8 , 2 0 2 1
M e r g e d
j b j m e r g e d 4 c o m m i t s i n t o
g i t h u b : m a i n f r o m
a n d e r s f u g m a n n : r e f a c t o r _ u s e _ o f _ i s G u a r d P h i
S e p 2 8 , 2 0 2 1
C o n v e r s a t i o n
4
C o m m i t s
4
C h e c k s
0
F i l e s c h a n g e d
C o n v e r s a t i o n
T h i s f i l e c o n t a i n s b i d i r e c t i o n a l U n i c o d e t e x t t h a t m a y b e i n t e r p r e t e d o r c o m p i l e d d i f f e r e n t l y t h a n w h a t a p p e a r s b e l o w . T o r e v i e w , o p e n t h e f i l e i n a n e d i t o r t h a t r e v e a l s h i d d e n U n i c o d e c h a r a c t e r s .
L e a r n m o r e a b o u t b i d i r e c t i o n a l U n i c o d e c h a r a c t e r s S h o w h i d d e n c h a r a c t e r s
C o n t r i b u t o r
A d d r e s s i n g r e v i e w c o m m e n t o n # 6 5 6 8 : T h i s P r u s e s t h e n e w p r e d i c a t e f o r R a n g e S S A : : i s G u a r d P h i / 4 .
I h a v e n o t d e l e t e d t h e o l d p r e d i c a t e R a n g e S S A : : i s G u a r d P h i / 3 , e v e n t h o u g h i t s n o t u s e d a n y m o r e t o a v o i d b r a k i n g o f e x t e r n a l q u e r i e s w h i c h m i g h t r e l y o n R a n g e S S A : : i s G u a r d P h i / 3
Sorry, something went wrong.
C + + : R e f a c t o r c o d e t o u s e p r e d i c a t e i s G u a r d P h i / 4
2 c 9 3 b c e
a n d e r s f u g m a n n r e q u e s t e d a r e v i e w
f r o m a t e a m a s a c o d e o w n e r
S e p t e m b e r 1 3 , 2 0 2 1 0 7 : 4 8
g i t h u b - a c t i o n s b o t a d d e d
t h e
C + +
l a b e l
S e p 1 3 , 2 0 2 1
a n d e r s f u g m a n n a d d e d
t h e
n o - c h a n g e - n o t e - r e q u i r e d
T h i s P R d o e s n o t n e e d a c h a n g e n o t e
l a b e l
S e p 1 3 , 2 0 2 1
C o n t r i b u t o r
j b j
c o m m e n t e d
I suggest marking RangeSSA::isGuardPhi/3as deprecated . It seems there wasn't a single need for it in our own codebase, and we found out it can be a footgun. Then a change note is needed.
As these changes affect the join order, a DCA run would be appropriate.
Sorry, something went wrong.
a n d e r s f u g m a n n m e n t i o n e d t h i s p u l l r e q u e s t
S e p 1 3 , 2 0 2 1
C + + : I m p r o v e p r e d i c a t e u p p e r B o u n d i n S i m p l e R a n g e A n a l y s i s
# 6 5 6 8
M e r g e d
C o n t r i b u t o r
A u t h o r
I suggest marking RangeSSA::isGuardPhi/3as deprecated . It seems there wasn't a single need for it in our own codebase, and we found out it can be a footgun. Then a change note is needed.
I will deprecate the function.
As these changes affect the join order, a DCA run would be appropriate.
DCA timings looks ok.
Sorry, something went wrong.
a n d e r s f u g m a n n
a d d e d 2 c o m m i t s
S e p t e m b e r 1 3 , 2 0 2 1 1 5 : 3 5
C + + : D e p r e c a t e R a n g e S S A : : i s G u a r d P h i / 3
8 e 9 a c 1 8
C + + : A d d D E P R E C A T E D t o d o c u m e n t a t i o n b l o c k
3 f 5 a b 6 0
C o n t r i b u t o r
j b j
c o m m e n t e d
There's an unrelated integration-test failure:
Running TRAP import for CodeQL database at /home/runner/work/semmle-code/semmle-code/integration-tests/posix-only/multi_extract/cluster/javascript...
foo.js.trap.gz, 3: com.semmle.util.exception.CatastrophicError: Tried to insert tuple with 2 columns into files which has 5 columns.
Maybe merging from main will fix it.
Sorry, something went wrong.
M e r g e r e m o t e - t r a c k i n g b r a n c h ' u p s t r e a m / m a i n ' i n t o r e f a c t o r _ u s e _ o f _ i s G …
…
7 9 5 4 9 c 2
…uardPhi
j b j
a p p r o v e d t h e s e c h a n g e s
S e p 2 8 , 2 0 2 1
V i e w r e v i e w e d c h a n g e s
C o n t r i b u t o r
j b j
l e f t a c o m m e n t
T h e r e w a s a p r o b l e m h i d i n g t h i s c o m m e n t .
C h o o s e a r e a s o n f o r h i d i n g t h i s c o m m e n t
T h e r e a s o n w i l l b e d i s p l a y e d t o d e s c r i b e t h i s c o m m e n t t o o t h e r s . L e a r n m o r e .
W h o o p s , t h i s P R h a d f a l l e n o f f m y r a d a r . L G T M .
Sorry, something went wrong.
j b j m e r g e d c o m m i t 9 1 4 e 6 2 1 i n t o
g i t h u b : m a i n S e p 2 8 , 2 0 2 1 a n d e r s f u g m a n n
d e l e t e d t h e
r e f a c t o r _ u s e _ o f _ i s G u a r d P h i
b r a n c h
S e p t e m b e r 2 9 , 2 0 2 1 0 7 : 1 9
S i g n u p f o r f r e e t o j o i n t h i s c o n v e r s a t i o n o n G i t H u b .
A l r e a d y h a v e a n a c c o u n t ?
S i g n i n t o c o m m e n t
jbj
jbj approved these changes
No one assigned
L a b e l s
C + +
n o - c h a n g e - n o t e - r e q u i r e d
T h i s P R d o e s n o t n e e d a c h a n g e n o t e
No milestone
Successfully merging this pull request may close these issues.
None yet
3 p a r t i c i p a n t s
A d d t h i s s u g g e s t i o n t o a b a t c h t h a t c a n b e a p p l i e d a s a s i n g l e c o m m i t . T h i s s u g g e s t i o n i s i n v a l i d b e c a u s e n o c h a n g e s w e r e m a d e t o t h e c o d e . S u g g e s t i o n s c a n n o t b e a p p l i e d w h i l e t h e p u l l r e q u e s t i s c l o s e d . S u g g e s t i o n s c a n n o t b e a p p l i e d w h i l e v i e w i n g a s u b s e t o f c h a n g e s . O n l y o n e s u g g e s t i o n p e r l i n e c a n b e a p p l i e d i n a b a t c h . A d d t h i s s u g g e s t i o n t o a b a t c h t h a t c a n b e a p p l i e d a s a s i n g l e c o m m i t . A p p l y i n g s u g g e s t i o n s o n d e l e t e d l i n e s i s n o t s u p p o r t e d . Y o u m u s t c h a n g e t h e e x i s t i n g c o d e i n t h i s l i n e i n o r d e r t o c r e a t e a v a l i d s u g g e s t i o n .
T h i s s u g g e s t i o n h a s b e e n a p p l i e d o r m a r k e d r e s o l v e d . S u g g e s t i o n s c a n n o t b e a p p l i e d f r o m p e n d i n g r e v i e w s . S u g g e s t i o n s c a n n o t b e a p p l i e d o n m u l t i - l i n e c o m m e n t s . S u g g e s t i o n s c a n n o t b e a p p l i e d w h i l e t h e p u l l r e q u e s t i s q u e u e d t o m e r g e . S u g g e s t i o n c a n n o t b e a p p l i e d r i g h t n o w . P l e a s e c h e c k b a c k l a t e r . F o o t e r
© 2 0 2 4 G i t H u b , I n c .
●
T e r m s ●
P r i v a c y ●
S e c u r i t y ●
S t a t u s ●
D o c s ●
C o n t a c t ●
M a n a g e c o o k i e s
●
D o n o t s h a r e m y p e r s o n a l i n f o r m a t i o n
Y o u c a n ’ t p e r f o r m t h a t a c t i o n a t t h i s t i m e .
andersfugmann
commented
andersfugmann
requested a review
from a team
as a code owner
github-actions
bot
added
the
C++
label
jbj
left a comment
jbj
merged commit 