| Dec |
JAN |
Feb |
|
29 |
|
| 2025 |
2026 |
2027 |
About this capture
The Wayback Machine - http://web.archive.org/web/20260129194417/https://github.com/github/codeql/pull/6710
Skip to content
Navigation Menu
Appearance settings
AI CODE CREATION
GitHub CopilotWrite better code with AI
GitHub SparkBuild and deploy intelligent apps
GitHub ModelsManage and compare prompts
MCP RegistryNewIntegrate external tools
DEVELOPER WORKFLOWS
ActionsAutomate any workflow
CodespacesInstant dev environments
IssuesPlan and track work
Code ReviewManage code changes
APPLICATION SECURITY
GitHub Advanced SecurityFind and fix vulnerabilities
Code securitySecure your code as you build
Secret protectionStop leaks before they start
EXPLORE
●Why GitHub
●Documentation
●Blog
●Changelog
●Marketplace
View all features
BY COMPANY SIZE
●Enterprises
●Small and medium teams
●Startups
●Nonprofits
BY USE CASE
●App Modernization
●DevSecOps
●DevOps
●CI/CD
●View all use cases
BY INDUSTRY
●Healthcare
●Financial services
●Manufacturing
●Government
●View all industries
View all solutions
EXPLORE BY TOPIC
●AI
●Software Development
●DevOps
●Security
●View all topics
EXPLORE BY TYPE
●Customer stories
●Events & webinars
●Ebooks & reports
●Business insights
●GitHub Skills
SUPPORT & SERVICES
●Documentation
●Customer support
●Community forum
●Trust center
●Partners
COMMUNITY
GitHub SponsorsFund open source developers
PROGRAMS
●Security Lab
●Maintainer Community
●Accelerator
●Archive Program
REPOSITORIES
●Topics
●Trending
●Collections
ENTERPRISE SOLUTIONS
Enterprise platformAI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced SecurityEnterprise-grade security features
Copilot for BusinessEnterprise-grade AI features
Premium SupportEnterprise-grade 24/7 support
●Pricing
Search or jump to...
Clear
Search syntax tips
Provide feedback
Saved searches
Use saved searches to filter your results more quickly
To see all available qualifiers, see our documentation.
Appearance settings
You signed in with another tab or window. Reload to refresh your session.
You signed out in another tab or window. Reload to refresh your session.
You switched accounts on another tab or window. Reload to refresh your session.
Dismiss alert
{{ message }}
github
/
codeql
Public
●
Notifications
You must be signed in to change notification settings
●
Fork
1.9k
Star
9.2k
●
Code
●
Issues
923
●
Pull requests
353
●
Discussions
●
Actions
●
Projects
0
●
Models
●
Security
0
●
Insights
Additional navigation options
●
Code
●
Issues
●
Pull requests
●
Discussions
●
Actions
●
Projects
●
Models
●
Security
●
Insights
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Sign up for GitHub
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
Sign in
to your account
Jump to bottom
Merged
MathiasVP
merged 8 commits into
github:main
from
ihsinme:ihsinme-patch-70
Oct 11, 2021
Merged
MathiasVP
merged 8 commits into
github:main
from
ihsinme:ihsinme-patch-70
Oct 11, 2021
Files changed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show hidden characters
Contributor
this query looks for functions for which there are wrapper functions with validation of arguments or work results.
the presence of wrapper functions already speaks of the developer's desire to ensure the launch of the function with additional safety. however, situations are possible when the developer has created a purely functional shell,
In this case, the detector will be useful in terms of assessing the need for an additional wrapper function.
From the specifics of the request, note the need to augment getEnclosingFunction when multifunctional functions are available. getEnclosingFunction may not work as expected. to fix these problems i used getFile.
links to real work results, I will add later. I am currently working on them with developers.
jackaudio/jack2#796
Sorry, something went wrong.
ihsinme
added 2commits
September 16, 2021 19:16
Add files via upload
b393c6a
Add files via upload
b6bcf9f
ihsinme
requested a review
from a team
as a code owner
September 16, 2021 16:19
github-actions
bot
added
C++
documentation
labels
Sep 16, 2021
MathiasVP
self-requested a review
September 20, 2021 11:44
MathiasVP
self-assigned this
Sep 20, 2021
MathiasVP
removed their request for review
September 20, 2021 11:44
MathiasVP
reviewed
Sep 20, 2021
View reviewed changes
Contributor
MathiasVP
left a comment
edited
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi@ihsinme,
Thanks for another contribution! Here's my first round of reviews.
Sorry, something went wrong.
cpp/ql/src/experimental/Security/CWE/CWE-1041/FindWrapperFunctions.ql
Show resolved
Hide resolved
Uh oh!
There was an error while loading. Please reload this page.
cpp/ql/src/experimental/Security/CWE/CWE-1041/FindWrapperFunctions.ql
Show resolved
Hide resolved
Uh oh!
There was an error while loading. Please reload this page.
cpp/ql/src/experimental/Security/CWE/CWE-1041/FindWrapperFunctions.ql
Outdated
Show resolved
Hide resolved
Uh oh!
There was an error while loading. Please reload this page.
cpp/ql/src/experimental/Security/CWE/CWE-1041/FindWrapperFunctions.ql
Outdated
Show resolved
Hide resolved
Uh oh!
There was an error while loading. Please reload this page.
cpp/ql/src/experimental/Security/CWE/CWE-1041/FindWrapperFunctions.ql
Outdated
Show resolved
Hide resolved
Uh oh!
There was an error while loading. Please reload this page.
cpp/ql/src/experimental/Security/CWE/CWE-1041/FindWrapperFunctions.ql
Outdated
Show resolved
Hide resolved
Uh oh!
There was an error while loading. Please reload this page.
cpp/ql/src/experimental/Security/CWE/CWE-1041/FindWrapperFunctions.ql
Outdated
Show resolved
Hide resolved
Uh oh!
There was an error while loading. Please reload this page.
cpp/ql/src/experimental/Security/CWE/CWE-1041/FindWrapperFunctions.ql
Outdated
Show resolved
Hide resolved
Uh oh!
There was an error while loading. Please reload this page.
cpp/ql/src/experimental/Security/CWE/CWE-1041/FindWrapperFunctions.ql
Show resolved
Hide resolved
Uh oh!
There was an error while loading. Please reload this page.
MathiasVP
reviewed
Sep 20, 2021
View reviewed changes
cpp/ql/src/experimental/Security/CWE/CWE-1041/FindWrapperFunctions.qhelp
Show resolved
Hide resolved
Uh oh!
There was an error while loading. Please reload this page.
cpp/ql/src/experimental/Security/CWE/CWE-1041/FindWrapperFunctions.qhelp
Outdated
Show resolved
Hide resolved
Uh oh!
There was an error while loading. Please reload this page.
ihsinme
and others
added 3commits
September 21, 2021 20:32
" data-pjax="true" class="Link--secondary markdown-title" href="/web/20260129194417/https://github.com/github/codeql/pull/6710/commits/88a257fcdc63c2504f3fbd697f401beade8f28d7">Apply suggestions from code review
88a257f
Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com>
Update FindWrapperFunctions.expected
18de9f0
Update FindWrapperFunctions.ql
13741ba
ihsinme
mentioned this pull request
Sep 29, 2021
CPP: Add query for CWE-1041 Use of Redundant Code
github/securitylab#443
Closed
1 task
MathiasVP
reviewed
Oct 8, 2021
View reviewed changes
cpp/ql/src/experimental/Security/CWE/CWE-1041/FindWrapperFunctions.ql
Outdated
Show resolved
Hide resolved
Uh oh!
There was an error while loading. Please reload this page.
cpp/ql/src/experimental/Security/CWE/CWE-1041/FindWrapperFunctions.ql
Show resolved
Hide resolved
Uh oh!
There was an error while loading. Please reload this page.
cpp/ql/src/experimental/Security/CWE/CWE-1041/FindWrapperFunctions.ql
Show resolved
Hide resolved
Uh oh!
There was an error while loading. Please reload this page.
ihsinme
and others
added 3commits
October 8, 2021 11:50
" data-pjax="true" class="Link--secondary markdown-title" href="/web/20260129194417/https://github.com/github/codeql/pull/6710/commits/d79596354e22d325ec1bfb7edc41a08fee5f405c">Update cpp/ql/src/experimental/Security/CWE/CWE-1041/FindWrapperFunct…
d795963
…ions.ql
Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com>
Update FindWrapperFunctions.qhelp
8c42545
Update FindWrapperFunctions.qhelp
4334acb
MathiasVP
approved these changes
Oct 11, 2021
View reviewed changes
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sorry, something went wrong.
MathiasVP
merged commit df8c399
into
github:main
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
MathiasVP
MathiasVP approved these changes
MathiasVP
C++
documentation
No milestone
Successfully merging this pull request may close these issues.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Footer
© 2026 GitHub, Inc.
●
Terms
●
Privacy
●
Security
●
Status
●
Community
●
Docs
●
Contact
●
●
ation
You can’t perform that action at this time.
ihsinme
commented
