The Wayback Machine - http://web.archive.org/web/20211025233155/https://github.com/github/codeql/pull/6823
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Add models for android.app.Notification builders #6823

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

@atorralba
Copy link
Contributor

@atorralba atorralba commented Oct 6, 2021

This PR adds models for Notification builders in the package android.app.

It mostly models the fluent behavior of Notification$Action$Builder and Notification$Builder with value-preserving steps, but also adds taint steps for methods that handle PendingIntents.

For instance, a PendingIntent can be added to an Action with Notification$Action(int,CharSequence,PendingIntent), then the Action can be added to a Notification$Builder with addAction and finally the Notification$Builder can create a Notification with build(), which can be sent with e.g. NotificationManager.notify.

@atorralba atorralba requested a review from as a code owner Oct 6, 2021
@github-actions github-actions bot added the Java label Oct 6, 2021
@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 6, 2021

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged. The following differences were found:

java

Generated file changes for java

  • Changes to framework-coverage-java.rst:
-    Android,``android.*``,45,233,70,,,3,67,,,
+    Android,``android.*``,45,314,70,,,3,67,,,
-    Totals,,143,5125,408,13,6,10,107,33,1,66
+    Totals,,143,5206,408,13,6,10,107,33,1,66
  • Changes to framework-coverage-java.csv:
+ android.app,,,81,,,,,,,,,,,,,,,,,,,,,13,68

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 8, 2021

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged. The following differences were found:

java

Generated file changes for java

  • Changes to framework-coverage-java.rst:
-    Android,``android.*``,45,245,70,,,3,67,,,
+    Android,``android.*``,45,326,70,,,3,67,,,
-    Totals,,143,5137,408,13,6,10,107,33,1,66
+    Totals,,143,5218,408,13,6,10,107,33,1,66
  • Changes to framework-coverage-java.csv:
+ android.app,,,81,,,,,,,,,,,,,,,,,,,,,13,68

@atorralba atorralba force-pushed the atorralba/android-notification-models branch from 1147943 to d374fe1 Oct 19, 2021
@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 19, 2021

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged. The following differences were found:

java

Generated file changes for java

  • Changes to framework-coverage-java.rst:
-    Android,``android.*``,45,285,70,,,3,67,,,
+    Android,``android.*``,45,366,70,,,3,67,,,
-    Totals,,143,5257,408,13,6,10,107,33,1,66
+    Totals,,143,5338,408,13,6,10,107,33,1,66
  • Changes to framework-coverage-java.csv:
+ android.app,,,81,,,,,,,,,,,,,,,,,,,,,13,68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant