Basic implementation of custom format strings for Text() function. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing permissions to comment. |
bryancroteau-MSFT
requested changes
Nov 3, 2021
src/libraries/Microsoft.PowerFx.Interpreter/Functions/LibraryDate.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.PowerFx.Interpreter/Functions/LibraryText.cs
Outdated
Show resolved
Hide resolved
src/tests/Microsoft.PowerFx.Core.Tests/ExpressionTestCases/Text.txt
Outdated
Show resolved
Hide resolved
src/tests/Microsoft.PowerFx.Interpreter.Tests/FileExpressionEvaluationTests.cs
Show resolved
Hide resolved
CarlosFigueiraMSFT
reviewed
Nov 3, 2021
src/libraries/Microsoft.PowerFx.Interpreter/Functions/LibraryText.cs
Outdated
Show resolved
Hide resolved
CarlosFigueiraMSFT
reviewed
Nov 3, 2021
src/tests/Microsoft.PowerFx.Core.Tests/ExpressionTestCases/Text.txt
Outdated
Show resolved
Hide resolved
CarlosFigueiraMSFT
reviewed
Nov 3, 2021
src/tests/Microsoft.PowerFx.Core.Tests/ExpressionTestCases/Text.txt
Outdated
Show resolved
Hide resolved
bryancroteau-MSFT
requested changes
Nov 3, 2021
src/libraries/Microsoft.PowerFx.Interpreter/Functions/LibraryText.cs
Outdated
Show resolved
Hide resolved
lesaltzm
reviewed
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
A very basic implementation for custom string formats for the Text() function.
Changes to the .csproj file were so that it's possible to add these projects to other solutions and make them project references to allow for editing and debugging across other projects that depend on these.
Also added one small change to the LibraryDate.cs to get one more test to pass that was part of a Text() test.
The text was updated successfully, but these errors were encountered: