[draft] DB reads as taint sources #7474
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaeluka
reviewed
Dec 22, 2021
| @@ -57,6 +57,26 @@ module Knex { | |||
| ) | |||
| } | |||
|
|
|||
| override DataFlow::Node getAQueryArgument() { none() } | |||
| override DataFlow::Node getAResult() { | |||
| ( | |||
There was a problem hiding this comment.
the knex model is a bit unusual in that it classifies both the expression producing the promise, as well as the await expression as database accesses. getAResult, in this case, follows the implementation of the characteristic predicate. LMK what you think.
intrigus-lgtm
reviewed
Dec 22, 2021
| @@ -84,6 +84,7 @@ abstract class FileNameSource extends DataFlow::Node { } | |||
| abstract class DatabaseAccess extends DataFlow::Node { | |||
| /** Gets an argument to this database access that is interpreted as a query. */ | |||
| abstract DataFlow::Node getAQueryArgument(); | |||
| abstract DataFlow::Node getAResult(); | |||
There was a problem hiding this comment.
Missing Ql Doc.
| (this = database().getMember("run").getACall() and result = this.getCallback(_).getParameter(1)) | ||
| or | ||
| (this = transaction().getMember("run").getACall() and result = this.getCallback(_).getParameter(1)) | ||
| or | ||
| (this = snapshot().getMember("run").getACall() and result = this.getCallback(_).getParameter(1)) |
There was a problem hiding this comment.
I think you should be able to simplify this using set-literals to
this = [database(), transaction(), snapshot()].getMember("run").getACall() and result = this.getCallback(_).getParameter(1))| @@ -52,3 +52,13 @@ class RemoteServerResponse extends HeuristicSource, RemoteFlowSource { | |||
|
|
|||
| override string getSourceType() { result = "a response from a remote server" } | |||
| } | |||
|
|
|||
| class DatabaseAccessResultRemoteFlowSource extends HeuristicSource, RemoteFlowSource { | |||
There was a problem hiding this comment.
Missing Ql Doc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This adds DB reads as taint sources in
AdditionalSources.qllas requested in github/codeql-javascript-team#348.This is not yet complete, as it's not handling streaming database queries where the result is consumed by a pipe call (eg, knex, spanner, have such features).
This also partially fixes (not yet complete) github/codeql-javascript-team#355
The text was updated successfully, but these errors were encountered: