The Wayback Machine - http://web.archive.org/web/20211229095632/https://github.com/apache/superset/issues/17415
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can we save the pagination setting to the chart metadata #17415

Open
3 tasks
J71-haha opened this issue Nov 12, 2021 · 4 comments
Open
3 tasks

can we save the pagination setting to the chart metadata #17415

J71-haha opened this issue Nov 12, 2021 · 4 comments
Labels
enhancement:request good first issue need:community-volunteer viz:chart-table
Projects
Community issues

Comments

@J71-haha
Copy link

@J71-haha J71-haha commented Nov 12, 2021

A clear and concise description of what the bug is.
The superset chart table sets the number of pagination rows to select the setting, and add the option of whether to select all

image
like this
image

How to reproduce the bug

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected results

what you expected to happen.

Actual results

what actually happens.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

(please complete the following information):

  • browser type and version:
  • superset version: superset version ：1.3.2
  • python version: python --version：3.7
  • node.js version: node -v
  • any feature flags active:

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.
@J71-haha J71-haha added the #bug label Nov 12, 2021
@junlincc
Copy link
Member

@junlincc junlincc commented Nov 12, 2021

make sense. should be an easy enhancement. Contribution is welcome! we are happy to guide you through the contribution process! :)

@junlincc junlincc added this to backlog in Community issues Nov 12, 2021
@Carlosbogo
Copy link

@Carlosbogo Carlosbogo commented Nov 12, 2021

Hi, I would love to help with this, but I am still getting used to working with github and I haven't worked in this repository before. Is there anyone already working on this? If not, I would like to start working on it.

@zhaoyongjie
Copy link
Contributor

@zhaoyongjie zhaoyongjie commented Dec 7, 2021

Hi @Carlosbogo, welcome to contribution, if you need to help, feel free ping me any time.

@Carlosbogo
Copy link

@Carlosbogo Carlosbogo commented Dec 8, 2021

Sorry for the delay, but I'm not sure if I understand the issue correctly:
Should the chart show the total number of entries instead of just "all" or am I missing the point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement:request good first issue need:community-volunteer viz:chart-table
Projects
Community issues
backlog
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@zhaoyongjie @J71-haha @junlincc @Carlosbogo and others