| Dec | JAN | Feb |
| 10 | ||
| 2021 | 2022 | 2023 |
COLLECTED BY
Collection: github.com
haby0
commented
|
If the path is controlled by some function calls of the |
|
The text was updated successfully, but these errors were encountered: |
Add shutil module path injection sinks
fed1d88
haby0
requested a review
from
as a code owner
github-actions
bot
added
the
Python
label
RasmusWL
left a comment
Sorry, something went wrong.
python/ql/lib/semmle/python/frameworks/Stdlib.qll Outdated| /** | ||
| * A call to the `shutil.copyfileobj` function. | ||
| * | ||
| * See https://docs.python.org/3/library/shutil.html#shutil.copyfileobj | ||
| */ | ||
| private class ShutilCopyfileobjCall extends FileSystemAccess::Range, DataFlow::CallCfgNode { | ||
| ShutilCopyfileobjCall() { this = shutil().getMember("copyfileobj").getACall() } | ||
|
|
||
| override DataFlow::Node getAPathArgument() { | ||
| result in [ | ||
| this.getArg(0), this.getArgByName("fsrc"), this.getArg(1), this.getArgByName("fdst") | ||
| ] | ||
| } | ||
| } | ||
|
|
RasmusWL
| /** | |
| * A call to the `shutil.copyfileobj` function. | |
| * | |
| * See https://docs.python.org/3/library/shutil.html#shutil.copyfileobj | |
| */ | |
| private class ShutilCopyfileobjCall extends FileSystemAccess::Range, DataFlow::CallCfgNode { | |
| ShutilCopyfileobjCall() { this = shutil().getMember("copyfileobj").getACall() } | |
| override DataFlow::Node getAPathArgument() { | |
| result in [ | |
| this.getArg(0), this.getArgByName("fsrc"), this.getArg(1), this.getArgByName("fdst") | |
| ] | |
| } | |
| } | |
| // TODO: once we have flow summaries, model `shutil.copyfileobj` which copies the content between its' file-like arguments. | |
| // See https://docs.python.org/3/library/shutil.html#shutil.copyfileobj |
Sorry, something went wrong.
Contributor Author
haby0
ShutilCopyfileobjCall need to be deleted?
Sorry, something went wrong.
Member
RasmusWL
getAPathArgument() to be none()
Sorry, something went wrong.
Contributor Author
haby0
Sorry, something went wrong.
Contributor Author
haby0
Sorry, something went wrong.
Contributor Author
haby0
commented
I don't quite understand the meaning of this sentence. |
Sorry, something went wrong.
Member
RasmusWL
commented
Oh, that was just referring to the inline comment I made. |
Sorry, something went wrong.
Add the test of shutil module in FileSystemAccess.py
05b0daa
RasmusWL
reviewed
RasmusWL
left a comment
python/ql/test/query-tests/Security/CWE-022-PathInjection/shutil_path_injection.py? Since we now highlight that we model these in python/ql/test/library-tests/frameworks/stdlib/FileSystemAccess.py, that is good enough Sorry, something went wrong.
python/ql/test/library-tests/frameworks/stdlib/FileSystemAccess.py Show resolved Hide resolved Contributor Author
haby0
commented
No problem! |
Sorry, something went wrong.
Delete shutil_path_injection.py file
759ec31
RasmusWL
approved these changes
RasmusWL
left a comment
Sorry, something went wrong.
Contributor Author
haby0
commented
Ok. I will try to apply for the bounty next. Do you think it's okay? |
Sorry, something went wrong.
Member
RasmusWL
commented
I'm not officially approving/rejecting bounties. If this additional modeling finds real vulnerabilities (that you can show), I don't see why you shouldn't be able to apply for a bounty. |
Sorry, something went wrong.
haby0
mentioned this pull request
haby0
commented
The application has been submitted. |
Sorry, something went wrong.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment No one assigned Labels Python No milestoneSuccessfully merging this pull request may close these issues.
None yet
2 participants Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. ● © 2022 GitHub, Inc. ●Terms ●Privacy ●Security ●Status ●Docs ●Contact GitHub ●Pricing ●API ●Training ●Blog ●About You can’t perform that action at this time. You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.