| Dec | JAN | Feb |
| 10 | ||
| 2021 | 2022 | 2023 |
COLLECTED BY
Collection: github.com
|
I added a QL-for-QL query that flags suspicious QLDoc for a predicate when:
This turns out to be good at identifying lots of QLDocs where the parameters mentioned in the qldoc do not match up with the actual parameter names.
I fixed most of the issues identified in the |
|
The text was updated successfully, but these errors were encountered: |
13055ef
to
cb0a1c3
02958e6
to
55cdef4
QL: Add query detecting suspiciously missing parameters from the QLDo…
969a27f
…c of a predicate
QL: add test for ql/missing-parameter-qldoc
3cba5ba
JS: fix most ql/missing-parameter-qldoc issues
cbb6cdd
sync files
f235748
QL: fix ql/missing-parameter-qldoc error in QL-for-QL
e75c767
55cdef4
to
e75c767
|
Could this be tuned to handle the case where all parameters have been renamed? That case can not be caught currently due to the first of your requirements. (I'm particularly interested in the /1 case) |
Sorry, something went wrong.
erik-krogh added 2commits
QL: also report missing QLDoc for parameters when no parameters are d…
8dfd1d9
…ocumented
JS: fix more instances of ql/missing-parameter-qldoc
f27c456
Contributor
Author
I thought it would be bad, but it worked great
I also found a few more tweaks to reduce the FP rate.
Edit: And I did some drive-by patching of explicit-this and redundant-cast, to further reduce the number of results in |
Sorry, something went wrong.
erik-krogh added 2commits
JS: apply the explicit-this patch
0047bb2
JS: run the redundant cast patch
f7bab5b
tausbn
requested changes
null, break, or return).
I don't know if there's a way to annotate inline code snippets with the desired highlighting language. Some MarkDown flavours support this, but it's not clear to me that the one in VSCode does.
Either way, I think we need to cut down on the number of false positives before merging this.
Sorry, something went wrong.
javascript/ql/examples/queries/dataflow/TemplateInjection/TemplateInjection.ql Outdated Show resolved Hide resolved ql/ql/src/queries/style/MissingParameterInQlDoc.ql Outdated Show resolved Hide resolved erik-krogh added 2commits
Merge branch 'main' into missDocParam
66d681f
apply suggestions from code review
d587c7f
erik-krogh
added 3commits
remove string constants from mentioned non-params
96ce590
add not as a keyword
0077df5
exclude annotation names
245bb79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
codeql-javascript
codeql-ruby
Requested changes must be addressed to merge this pull request.
No one assigned Labels JS no-change-note-required Python QL-for-QL Ruby No milestoneSuccessfully merging this pull request may close these issues.
None yet
3 participants Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. ● © 2022 GitHub, Inc. ●Terms ●Privacy ●Security ●Status ●Docs ●Contact GitHub ●Pricing ●API ●Training ●Blog ●About You can’t perform that action at this time. You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.