| Dec | JAN | Feb |
| 10 | ||
| 2021 | 2022 | 2023 |
COLLECTED BY
Collection: github.com
codeql test run
#7515
codeql test run
#7515
hvitved
commented
|
Passing |
|
The text was updated successfully, but these errors were encountered: |
C#: Introduce extractor mode to identify DBs created with `codeql tes…
60e3964
…t run`
hvitved
requested a review
from
as a code owner
github-actions
bot
added
the
C#
label
michaelnebel
left a comment
Sorry, something went wrong.
csharp/extractor/Semmle.Extraction.CIL.Driver/ExtractorOptions.cs| { | ||
| if (arg == "--verbose") |
michaelnebel
Sorry, something went wrong.
csharp/extractor/Semmle.Extraction.CIL.Driver/ExtractorOptions.cs| { | ||
| private readonly AssemblyList assemblyList = new AssemblyList(); | ||
|
|
||
| public ExtractorOptions(string[] args) | ||
| { | ||
| Verbosity = Verbosity.Info; | ||
| Threads = System.Environment.ProcessorCount; | ||
| PDB = true; |
michaelnebel
Sorry, something went wrong.
csharp/extractor/Semmle.Extraction.CIL/Entities/PdbSourceFile.cs| @@ -25,7 +25,7 @@ public override IEnumerable<IExtractionProduct> Contents | |||
| else | |||
| Context.TrapWriter.Archive(TransformedPath, text); | |||
|
|
|||
| yield return Tuples.file_extraction_mode(this, 2); | |||
| yield return Tuples.file_extraction_mode(this, Context.Extractor.Mode | ExtractorMode.Pdb); | |||
michaelnebel
Sorry, something went wrong.
csharp/extractor/Semmle.Extraction.CSharp/Entities/File.cs| @@ -61,7 +61,7 @@ public override void Populate(TextWriter trapFile) | |||
| } | |||
| } | |||
|
|
|||
| trapFile.file_extraction_mode(this, Context.Extractor.Standalone ? 1 : 0); | |||
| trapFile.file_extraction_mode(this, Context.Extractor.Mode); | |||
michaelnebel
Sorry, something went wrong.
csharp/extractor/Semmle.Extraction/Extractor/StandaloneExtractor.cs| private readonly ExtractorMode mode; | ||
| public override ExtractorMode Mode => mode; |
michaelnebel
| private readonly ExtractorMode mode; | |
| public override ExtractorMode Mode => mode; | |
| public override ExtractorMode Mode { get; }; |
Sorry, something went wrong.
csharp/extractor/Semmle.Extraction/Extractor/StandaloneExtractor.cs| mode = ExtractorMode.Standalone; | ||
| if (options.QlTest) | ||
| mode |= ExtractorMode.QlTest; |
michaelnebel
Sorry, something went wrong.
csharp/extractor/Semmle.Extraction/Extractor/TracingExtractor.cs| public override bool Standalone => false; | ||
|
|
||
| private readonly ExtractorMode mode; | ||
| public override ExtractorMode Mode => mode; |
michaelnebel
Sorry, something went wrong.
csharp/extractor/Semmle.Extraction/Options.cs| @@ -37,13 +37,18 @@ public abstract class CommonOptions : ICommandLineOptions | |||
| /// <summary> | |||
| /// Whether to extract PDB information. | |||
| /// </summary> | |||
| public bool PDB { get; private set; } = false; | |||
| public bool PDB { get; set; } = false; | |||
michaelnebel
Sorry, something went wrong.
csharp/extractor/Semmle.Extraction/Options.cs| /// <summary> | ||
| /// Whether extraction is done using `codeql test run`. | ||
| /// </summary> | ||
| public bool QlTest { get; private set; } = false; |
michaelnebel
Sorry, something went wrong.
csharp/ql/lib/semmle/code/csharp/File.qll| predicate isPdbSourceFile() { | ||
| exists(int i | | ||
| file_extraction_mode(this, i) and | ||
| i.bitAnd(2) = 2 |
michaelnebel
Sorry, something went wrong.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to commentAt least 1 approving review is required to merge this pull request.
No one assigned Labels C# No milestoneSuccessfully merging this pull request may close these issues.
None yet
2 participants Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. ● © 2022 GitHub, Inc. ●Terms ●Privacy ●Security ●Status ●Docs ●Contact GitHub ●Pricing ●API ●Training ●Blog ●About You can’t perform that action at this time. You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.