crypto: fix webcrypto.subtle signature
#41761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested: |
Mesteery
approved these changes
Jan 29, 2022
VoltrexMaster
approved these changes
Jan 29, 2022
aduh95
changed the title
webcrpto.subtle signaturewebcrypto.subtle signature
panva
approved these changes
Jan 30, 2022
This comment has been hidden.
This comment has been hidden.
|
Is this actually required by the spec or WPT? |
|
It's always difficult to find things in Web IDL, but I think this is the relevant part: https://webidl.spec.whatwg.org/#dfn-attribute-getter
|
|
Thanks @targos. |
tniessen
approved these changes
Jan 31, 2022
|
To whoever lands this: there's a typo in the commit message |
lpinca
approved these changes
Jan 31, 2022
|
Landed in 7123a00 |
ruyadorno
added a commit
that referenced
this issue
Feb 8, 2022
PR-URL: #41761 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
added a commit
that referenced
this issue
Mar 2, 2022
PR-URL: #41761 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
added a commit
that referenced
this issue
Mar 3, 2022
PR-URL: #41761 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
added a commit
that referenced
this issue
Mar 14, 2022
PR-URL: #41761 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
"get subtle""get subtle""get subtle""get subtle"TypeError: Cannot read properties of undefined (reading 'name')This PR aligns Node.js with the rest of the ecosystem.