JS: promote the js/jwt-missing-verification query out of experimental #7740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
added
the
Awaiting evaluation
erik-krogh
removed
the
Awaiting evaluation
|
it looks good to me, but I'd like someone else to take a look as well :) |
esbena
reviewed
Jan 28, 2022
javascript/ql/src/Security/CWE-347/MissingJWTKeyVerification.ql
Outdated
Show resolved
Hide resolved
javascript/ql/src/Security/CWE-347/MissingJWTKeyVerification.ql
Outdated
Show resolved
Hide resolved
esbena
previously approved these changes
Jan 28, 2022
esbena
added
the
ready-for-doc-review
mchammer01
changed the title
esbena
previously approved these changes
Jan 31, 2022
mchammer01
previously approved these changes
Jan 31, 2022
Contributor
mchammer01
left a comment
mchammer01
left a comment
There was a problem hiding this comment.
@erik-krogh - LGTM ✨
A few minor suggestions and a typo.
javascript/ql/src/change-notes/2022-01-25-missing-jwt-verification.md
Outdated
Show resolved
Hide resolved
javascript/ql/src/Security/CWE-347/MissingJWTKeyVerification.qhelp
Outdated
Show resolved
Hide resolved
javascript/ql/src/Security/CWE-347/MissingJWTKeyVerification.qhelp
Outdated
Show resolved
Hide resolved
javascript/ql/src/Security/CWE-347/MissingJWTKeyVerification.qhelp
Outdated
Show resolved
Hide resolved
javascript/ql/src/Security/CWE-347/MissingJWTKeyVerification.qhelp
Outdated
Show resolved
Hide resolved
Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>
mchammer01
approved these changes
Feb 1, 2022
Contributor
mchammer01
left a comment
mchammer01
left a comment
There was a problem hiding this comment.
Thanks for addressing my comments 💖
esbena
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evaluation looks OK. No change in alerts, and performance that seems to be within the margin of error.
The query flags basically the same issue as this java query.