| Nov |
DEC |
Jan |
|
31 |
|
| 2024 |
2025 |
2026 |
About this capture
The Wayback Machine - http://web.archive.org/web/20251231132337/https://github.com/github/codeql/pull/7703
Skip to content
Navigation Menu
Appearance settings
AI CODE CREATION
GitHub CopilotWrite better code with AI
GitHub SparkBuild and deploy intelligent apps
GitHub ModelsManage and compare prompts
MCP RegistryNewIntegrate external tools
DEVELOPER WORKFLOWS
ActionsAutomate any workflow
CodespacesInstant dev environments
IssuesPlan and track work
Code ReviewManage code changes
APPLICATION SECURITY
GitHub Advanced SecurityFind and fix vulnerabilities
Code securitySecure your code as you build
Secret protectionStop leaks before they start
EXPLORE
●Why GitHub
●Documentation
●Blog
●Changelog
●Marketplace
View all features
BY COMPANY SIZE
●Enterprises
●Small and medium teams
●Startups
●Nonprofits
BY USE CASE
●App Modernization
●DevSecOps
●DevOps
●CI/CD
●View all use cases
BY INDUSTRY
●Healthcare
●Financial services
●Manufacturing
●Government
●View all industries
View all solutions
EXPLORE BY TOPIC
●AI
●Software Development
●DevOps
●Security
●View all topics
EXPLORE BY TYPE
●Customer stories
●Events & webinars
●Ebooks & reports
●Business insights
●GitHub Skills
SUPPORT & SERVICES
●Documentation
●Customer support
●Community forum
●Trust center
●Partners
COMMUNITY
GitHub SponsorsFund open source developers
PROGRAMS
●Security Lab
●Maintainer Community
●Accelerator
●Archive Program
REPOSITORIES
●Topics
●Trending
●Collections
ENTERPRISE SOLUTIONS
Enterprise platformAI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced SecurityEnterprise-grade security features
Copilot for BusinessEnterprise-grade AI features
Premium SupportEnterprise-grade 24/7 support
●Pricing
Search or jump to...
Clear
Search syntax tips
Provide feedback
Saved searches
Use saved searches to filter your results more quickly
To see all available qualifiers, see our documentation.
Appearance settings
You signed in with another tab or window. Reload to refresh your session.
You signed out in another tab or window. Reload to refresh your session.
You switched accounts on another tab or window. Reload to refresh your session.
Dismiss alert
{{ message }}
github
/
codeql
Public
●
Notifications
You must be signed in to change notification settings
●
Fork
1.9k
Star
9.1k
●
Code
●
Issues
917
●
Pull requests
369
●
Discussions
●
Actions
●
Projects
0
●
Models
●
Security
Uh oh!
There was an error while loading. Please reload this page.
●
Insights
Additional navigation options
●
Code
●
Issues
●
Pull requests
●
Discussions
●
Actions
●
Projects
●
Models
●
Security
●
Insights
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Sign up for GitHub
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
Sign in
to your account
Jump to bottom
Merged
MathiasVP
merged 7 commits into
github:main
from
geoffw0:getslocal
Jan 28, 2022
Merged
MathiasVP
merged 7 commits into
github:main
from
geoffw0:getslocal
Jan 28, 2022
Files changed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show hidden characters
Contributor
As I understand it gets should be a LocalFlowSourceFunction not a RemoteFlowSourceFunction (unlike fgets which may at least be a remote source). Fixing this required splitting the model in two, though a few parts did simplify afterwards.
This change is mostly for correctness but will fix the odd false positive, such as the test case added for cpp/cleartext-transmission (which confusingly is and remains a true positive for cpp/cleartext-storage-buffer, tested alongside, because that query is defined to not care about it being a remote source).
Sorry, something went wrong.
geoffw0
added 2commits
January 21, 2022 17:29
C++: Add test case.
79735f5
C++: Split 'gets' model and make it a local source.
4326e6f
geoffw0
added
C++
no-change-note-required
This PR does not need a change note
labels
Jan 21, 2022
geoffw0
requested a review
from a team
as a code owner
January 21, 2022 17:37
MathiasVP
previously approved these changes
Jan 21, 2022
View reviewed changes
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Both of my comments are really something that we should fix as follow-ups, so feel free to merge this PR without changing anything.
Sorry, something went wrong.
cpp/ql/lib/semmle/code/cpp/models/implementations/Gets.qll
Outdated
Show resolved
Hide resolved
Uh oh!
There was an error while loading. Please reload this page.
cpp/ql/lib/semmle/code/cpp/models/implementations/Gets.qll
Show resolved
Hide resolved
Uh oh!
There was an error while loading. Please reload this page.
C++: Fix up isParameterDeref.
588447d
geoffw0
dismissed
MathiasVP’s stale review
via
588447d
January 24, 2022 11:06
C++: Autoformat.
47528dd
Contributor
Author
Sorry, something went wrong.
geoffw0
added 2commits
January 28, 2022 15:58
Merge branch 'main' into getslocal
036e149
C++: Fixes to gets models.
af09dd8
MathiasVP
reviewed
Jan 28, 2022
View reviewed changes
cpp/ql/lib/semmle/code/cpp/models/implementations/Gets.qll
Outdated
Show resolved
Hide resolved
Uh oh!
There was an error while loading. Please reload this page.
C++: Remove empty predicate / extends.
0396a84
MathiasVP
approved these changes
Jan 28, 2022
View reviewed changes
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sorry, something went wrong.
MathiasVP
merged commit bb2feda
into
github:main
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
MathiasVP
MathiasVP approved these changes
No one assigned
C++
no-change-note-required
This PR does not need a change note
No milestone
Successfully merging this pull request may close these issues.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Footer
© 2025 GitHub, Inc.
●
Terms
●
Privacy
●
Security
●
Status
●
Community
●
Docs
●
Contact
●
●
ation
You can’t perform that action at this time.
geoffw0
commented
MathiasVP
left a comment