The Wayback Machine - http://web.archive.org/web/20201116034309/https://github.com/google/wire/pull/101
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: code gen copies over anonymous imports #101

Merged
merged 3 commits into from Jan 7, 2019
Merged

Conversation

@doodlesbykumbi
Copy link
Contributor

@doodlesbykumbi doodlesbykumbi commented Jan 5, 2019

Fixes #94

@googlebot googlebot added the cla: yes label Jan 5, 2019
@zombiezen zombiezen self-assigned this Jan 7, 2019
@zombiezen zombiezen self-requested a review Jan 7, 2019
Copy link
Collaborator

@zombiezen zombiezen left a comment

LGTM. Thanks @doodlesbykumbi! 🙂

zombiezen added 2 commits Jan 7, 2019
@zombiezen zombiezen merged commit f285c07 into google:master Jan 7, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
coverage/coveralls Coverage increased (+0.2%) to 65.892%
Details
@doodlesbykumbi
Copy link
Contributor Author

@doodlesbykumbi doodlesbykumbi commented Jan 7, 2019

@zombiezen your change took out the intentionally duplicated example.com/anon1...

@zombiezen
Copy link
Collaborator

@zombiezen zombiezen commented Jan 7, 2019

Oops! I should have checked the gofmt diff. I'll fix that.

zombiezen added a commit to zombiezen/wire that referenced this pull request Jan 7, 2019
This got removed as part of my gofmt run on google#101.
zombiezen added a commit that referenced this pull request Jan 7, 2019
This got removed as part of my gofmt run on #101.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.