The Wayback Machine - http://web.archive.org/web/20220612141221/https://github.com/python/devguide/issues/674
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sect. 3 (Lifecycle of a Pull Request) does not mention Misc/NEWS.d/next and blurb #674

Open

jwuttke opened this issue Apr 14, 2021 · 1 comment
Open

Sect. 3 (Lifecycle of a Pull Request) does not mention Misc/NEWS.d/next and blurb #674

jwuttke opened this issue Apr 14, 2021 · 1 comment

Comments

@jwuttke
Copy link

@jwuttke jwuttke commented Apr 14, 2021

The explanations how to create a pull request are incomplete. They should mention

  • That in general a news file is requested.
  • How this file can be generated using blurb.
  • Under which conditions the "skip news" label can be set.
@methane
Copy link
Member

@methane methane commented Apr 14, 2021

blurb and news entry are described in https://devguide.python.org/committing/#updating-news-and-what-s-new-in-python

Maybe, it's old workflow. Contributor writes patch without news. Core developer commit the patch with news.

In current workflow, we ask contributors to write news entry. So let's move the section from "16. Accepting Pull Requests" to "3. Lifecycle of a Pull Request".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@methane @jwuttke