The Wayback Machine - http://web.archive.org/web/20220419234123/https://github.com/pingcap/docs/pull/7032
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize wording for tidb-computing #7032

Merged
merged 2 commits into from Dec 15, 2021
Merged

Optimize wording for tidb-computing #7032

merged 2 commits into from Dec 15, 2021

Conversation

shichun-0415
Copy link
Contributor

@shichun-0415 shichun-0415 commented Nov 26, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Optimize wording for tidb-computing

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Nov 26, 2021 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn Nov 26, 2021
@ti-chi-bot ti-chi-bot added missing-translation-status size/XS labels Nov 26, 2021
@shichun-0415 shichun-0415 added needs-cherry-pick-release-4.0 needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 area/sql-infra translation/from-docs-cn type/bug-fix and removed missing-translation-status size/XS labels Nov 26, 2021
TomShawn
TomShawn reviewed Dec 15, 2021
View changes
tidb-computing.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added the require-LGT1 label Dec 15, 2021
@ti-chi-bot ti-chi-bot added the size/XS label Dec 15, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 label Dec 15, 2021
@TomShawn
Copy link
Collaborator

@TomShawn TomShawn commented Dec 15, 2021

/merge

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 15, 2021

This pull request has been accepted and is ready to merge.

Commit hash: f46b9da

@ti-chi-bot ti-chi-bot added the status/can-merge label Dec 15, 2021
@ti-chi-bot ti-chi-bot merged commit ae7d6fb into pingcap:master Dec 15, 2021
4 checks passed

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 15, 2021

Merged
14 tasks
@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 15, 2021

In response to a cherrypick label: new pull request created: #7232.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 15, 2021

Merged
14 tasks
@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 15, 2021

In response to a cherrypick label: new pull request created: #7233.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 15, 2021

Merged
14 tasks
@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 15, 2021

In response to a cherrypick label: new pull request created: #7234.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 15, 2021

Merged
14 tasks
@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 15, 2021

In response to a cherrypick label: new pull request created: #7235.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 15, 2021

Merged
14 tasks
@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 15, 2021

In response to a cherrypick label: new pull request created: #7236.

ti-chi-bot added a commit that referenced this issue Dec 15, 2021
@ti-chi-bot
Optimize wording for tidb-computing (#7032) (#7233)
66a8e3c
ti-chi-bot added a commit that referenced this issue Dec 15, 2021
@ti-chi-bot
Optimize wording for tidb-computing (#7032) (#7232)
98cb847
ti-chi-bot added a commit that referenced this issue Dec 15, 2021
@ti-chi-bot
Optimize wording for tidb-computing (#7032) (#7236)
5babf04
ti-chi-bot added a commit that referenced this issue Dec 15, 2021
@ti-chi-bot
Optimize wording for tidb-computing (#7032) (#7235)
b60ecb4
ti-chi-bot added a commit that referenced this issue Dec 15, 2021
@ti-chi-bot
Optimize wording for tidb-computing (#7032) (#7234)
b773868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn

Assignees
No one assigned
Labels
area/sql-infra needs-cherry-pick-release-4.0 needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 require-LGT1 size/XS status/can-merge status/LGT1 translation/from-docs-cn type/bug-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shichun-0415 @ti-chi-bot @TomShawn