The Wayback Machine - http://web.archive.org/web/20220419231938/https://github.com/pingcap/docs/pull/8080
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TiFlash to the credits.md #8080

Merged
merged 1 commit into from Apr 7, 2022
Merged

Add TiFlash to the credits.md #8080

merged 1 commit into from Apr 7, 2022

Conversation

yahonda
Copy link
Contributor

@yahonda yahonda commented Apr 6, 2022 •
edited by shichun-0415

What is changed, added or deleted? (Required)

Add TiFlash to the credits.md because now TiFlash repository https://github.com/pingcap/tiflash is public.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Apr 6, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from shichun-0415 Apr 6, 2022
@ti-chi-bot ti-chi-bot added missing-translation-status size/XS labels Apr 6, 2022
shichun-0415
shichun-0415 approved these changes Apr 7, 2022
View changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 label Apr 7, 2022
@shichun-0415 shichun-0415 added translation/doing needs-cherry-pick-release-6.0 and removed missing-translation-status labels Apr 7, 2022
@shichun-0415 shichun-0415 self-assigned this Apr 7, 2022
@shichun-0415
Copy link
Contributor

@shichun-0415 shichun-0415 commented Apr 7, 2022

/cc @moyun

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Apr 7, 2022

@shichun-0415: GitHub didn't allow me to request PR reviews from the following users: moyun.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @moyun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zanmato1984
zanmato1984 approved these changes Apr 7, 2022
View changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

LGTM

@shichun-0415
Copy link
Contributor

@shichun-0415 shichun-0415 commented Apr 7, 2022

/remove status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 label Apr 7, 2022
@shichun-0415
Copy link
Contributor

@shichun-0415 shichun-0415 commented Apr 7, 2022

/merge

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Apr 7, 2022

This pull request has been accepted and is ready to merge.

Commit hash: 01fcfd3

@ti-chi-bot ti-chi-bot added the status/can-merge label Apr 7, 2022
@ti-chi-bot ti-chi-bot merged commit 1fbc203 into pingcap:master Apr 7, 2022
4 checks passed
@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Apr 7, 2022

In response to a cherrypick label: new pull request created: #8106.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 7, 2022

Merged
15 tasks
ti-chi-bot added a commit that referenced this issue Apr 7, 2022
@ti-chi-bot
Add TiFlash to the credits.md (#8080) (#8106)
9c0b952
@moyun
Copy link

@moyun moyun commented Apr 7, 2022

LGTM

@shichun-0415 shichun-0415 mentioned this pull request Apr 11, 2022

Merged
16 tasks
@shichun-0415 shichun-0415 removed the translation/doing label Apr 11, 2022
@ti-chi-bot ti-chi-bot added the missing-translation-status label Apr 11, 2022
@shichun-0415 shichun-0415 removed the missing-translation-status label Apr 11, 2022
@shichun-0415 shichun-0415 added the translation/done label Apr 11, 2022

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 11, 2022

Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanmato1984 zanmato1984

@shichun-0415 shichun-0415

@ilovesoup ilovesoup

Assignees

@shichun-0415 shichun-0415

Labels
needs-cherry-pick-release-6.0 size/XS status/can-merge status/LGT1 status/LGT2 translation/done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yahonda @ti-chi-bot @shichun-0415 @moyun @zanmato1984