Prepare Realtime for Marketplaces #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Packer & Ansible settings to prepare for AWS/DO Marketplaces
`source_ami`'s default is set to x64 Ubuntu 18.04 EBS HVM in ap-southeast-1 (Singpore), but ami codes change between regions, so this should be a user variable along with `region`.
kiwicopple
added a commit
to kiwicopple/realtime
that referenced
this issue
Jun 9, 2021
* chore: update Packer & Ansible files Update Packer & Ansible settings to prepare for AWS/DO Marketplaces * chore: set aws.json's `source_ami` to be user var `source_ami`'s default is set to x64 Ubuntu 18.04 EBS HVM in ap-southeast-1 (Singpore), but ami codes change between regions, so this should be a user variable along with `region`. * fix: get SECRET_KEY_BASE from env * chore: proper cleanup of Ansible tmp files * docs: better error messages for SECRET_KEY_BASE * ci: fix artifact naming of release assets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
SECRET_KEY_BASEfrom env instead of hardcoded values