Data flow: Introduce 'with/without content' summary components#8898
Merged
hvitved merged 3 commits intogithub:mainfrom May 11, 2022
Merged
Data flow: Introduce 'with/without content' summary components#8898hvitved merged 3 commits intogithub:mainfrom
hvitved merged 3 commits intogithub:mainfrom
Conversation
hvitved
force-pushed
the
dataflow/clear-expect-summary-components
branch
3 times, most recently
from
7566f09 to
da82ed8
Compare
hvitved
changed the title
hvitved
force-pushed
the
dataflow/clear-expect-summary-components
branch
3 times, most recently
from
02a9ee1 to
46f4eb9
Compare
hvitved
force-pushed
the
dataflow/clear-expect-summary-components
branch
from
46f4eb9 to
04cc738
Compare
aschackmull
approved these changes
May 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
to
FlowSummaryImpl.qllfor C#, Java, and Ruby.The new
SummaryComponents are only meant to be used in input specifications, and they gives rise to new synthesized nodesnat whichclearsContent(n, c)resp.expectsContent(n, c)holds. This means that we can interpretSummarizedCallable::clearsContent(ParameterPosition ppos, ContentSet cs)as a summary with input stackand output stack
Ultimately, we should get rid of
SummarizedCallable::clearsContent(ParameterPosition ppos, ContentSet cs)and use summaries like the above instead, but that will be done follow-up.