The Wayback Machine - http://web.archive.org/web/20221114063947/https://github.com/tiangolo/fastapi/pull/4908
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Add docs recommending Union over Optional and migrate source examples #4908

Merged
merged 8 commits into from May 14, 2022
Merged

📝 Add docs recommending Union over Optional and migrate source examples #4908

merged 8 commits into from May 14, 2022

Conversation

tiangolo
Copy link
Owner

@tiangolo tiangolo commented May 14, 2022

📝 Add docs recommending Union over Optional and migrate source examples

@codecov
Copy link

codecov bot commented May 14, 2022 •
edited

Codecov Report

Merging #4908 (fc0c53d) into master (c5be1b0) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #4908   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          531       531           
  Lines        13634     13634           
=========================================
  Hits         13634     13634
Impacted Files Coverage Δ
docs_src/additional_responses/tutorial002.py 100.00% <100.00%> (ø)
docs_src/additional_responses/tutorial004.py 100.00% <100.00%> (ø)
docs_src/background_tasks/tutorial002.py 100.00% <100.00%> (ø)
docs_src/body/tutorial001.py 100.00% <100.00%> (ø)
docs_src/body_updates/tutorial001.py 100.00% <100.00%> (ø)
docs_src/body_updates/tutorial001_py39.py 100.00% <100.00%> (ø)
docs_src/dataclasses/tutorial001.py 100.00% <100.00%> (ø)
docs_src/dataclasses/tutorial002.py 100.00% <100.00%> (ø)
docs_src/dataclasses/tutorial003.py 100.00% <100.00%> (ø)
docs_src/dependencies/tutorial001.py 100.00% <100.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5be1b0...fc0c53d. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2022

🚀 Deployed on https://627f9911dc5fe760a0046e2d--fastapi.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2022

📝 Docs preview for commit fc0c53d at: https://627f997f8e33d562842f92ac--fastapi.netlify.app

@tiangolo tiangolo merged commit ca437cd into master May 14, 2022
9 checks passed
@tiangolo tiangolo deleted the recomment-union-over-optional branch May 14, 2022
JeanArhancet pushed a commit to JeanArhancet/fastapi that referenced this pull request Aug 20, 2022
@tiangolo @JeanArhancet
📝 Add docs recommending Union over Optional and migrate source ex 1¤7
1ca4372 
…amples (tiangolo#4908)

* 📝 Add docs recommending Union over Optional

* 📝 Update docs recommending Union over Optional

* 📝 Update source examples for docs, recommend Union over Optional

* 📝 Update highlighted lines with updated source examples

* 📝 Update highlighted lines in Markdown with recent code changes

* 📝 Update docs, use Union instead of Optional

* ♻️ Update source examples to recommend Union over Optional

* 🎨 Update highlighted code in Markdown after moving from Optional to Union
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tiangolo