The Wayback Machine - http://web.archive.org/web/20220612212921/https://github.com/apache/superset/issues/18234
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mixed time-series; time-series bar chart v2] D3 format of saved metric is ignored; bar values ignore D3 format of the chart #18234

Open
3 tasks done
rumbin opened this issue Jan 31, 2022 · 1 comment
Labels
#bug good first issue inactive preset:cares validation:validated

Comments

@rumbin
Copy link
Contributor

@rumbin rumbin commented Jan 31, 2022

I can replicate this on both, mixed time-series and time-series bar chart v2.

The D3 format of a saved metric is not respected in the

  • y-axis labels
  • tooltips
  • Show Values

How to reproduce the bug

  1. Have a saved metric defined for a dataset
  2. Have a custom D3 format defined for this metric
  3. Create a diagram of type mixed time-series or ** time-series bar chart v2**
  4. Activate the Show Values option

Expected results

The y-axis labels, the tooltips and the bar values are formatted according to the defined D3 format of the metric.

Actual results

The d3 format of the metric is entirely ignored.

When overriding the y-axis format via the chart's Customize settings, the y-labels and tooltips are respecting this override.
The bar values need some differentiation here, though:

  • time-series bar chart v2: respects the chart's y-axis D3 format
  • mixed time-series: does not respect the chart's y-axis D3 format

Screenshots

  • time-series bar chart v2

bar_chart_d3_format

  • mixed time-series: (also notice how the bar values are not customizable here)

mixed_time-series_d3_format

Environment

  • browser type and version: Chrome 96.0.4664.93
  • superset version: 1.4.0
  • all other versions: as defined in Superset's Docker image
  • Feature flags:
# stable:
      "THUMBNAILS": True,
      "SQLLAB_BACKEND_PERSISTENCE": True,
      "ENABLE_TEMPLATE_PROCESSING": True,
      "DASHBOARD_CROSS_FILTERS": True,

      # experimental:
      "ALERT_REPORTS": True,
      "ALERTS_ATTACH_REPORTS": True,
      "DASHBOARD_NATIVE_FILTERS": True,

      # unclassified:
      "ENABLE_EXPLORE_DRAG_AND_DROP": True,
      "ENABLE_DND_WITH_CLICK_UX": True,

      # development:
      "DASHBOARD_NATIVE_FILTERS_SET": True

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@rumbin rumbin added the #bug label Jan 31, 2022
@geido geido added good first issue preset:cares validation:validated labels Feb 1, 2022
@stale
Copy link

@stale stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive label Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug good first issue inactive preset:cares validation:validated
Projects
None yet
Development

No branches or pull requests

2 participants