The Wayback Machine - http://web.archive.org/web/20220325060414/https://github.com/SasanLabs/VulnerableApp-facade/issues/64
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up JavaScript and Typescript linting and formatting tools #64

Open

Dripcoding opened this issue Mar 21, 2022 · 1 comment
Open

Set up JavaScript and Typescript linting and formatting tools #64

Dripcoding opened this issue Mar 21, 2022 · 1 comment
Assignees

Comments

@Dripcoding
Copy link
Contributor

@Dripcoding Dripcoding commented Mar 21, 2022

Is your feature request related to a problem? Please describe.
I would like to automate linting and formatting when contributing code. This will make collaboration easier and helps ensure code-quality.

Describe the solution you'd like
I would like ESLint, TSLint, Husky, Prettier to be configured for the project locally and as part of the ci/cd pipeline.

Describe alternatives you've considered
I've also considered looking in to using code quality tools available on the Github Actions marketplace.

Additional context
NA

Would you like to help fix this issue?
Yes, I'd like to work on this feature.

@preetkaran20
Copy link
Member

@preetkaran20 preetkaran20 commented Mar 21, 2022

We already have prettier configured https://github.com/SasanLabs/VulnerableApp-facade/blob/main/facade-app/package.json#L27

If you still think we can make it better or integrate with npm build please go ahead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants