The Wayback Machine - http://web.archive.org/web/20201221235644/https://github.com/kudobuilder/kudo/issues/1063
Skip to content

/ kudo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore IDE files by default #1063

Open
camilamacedo86 opened this issue Nov 15, 2019 · 5 comments
Open

Ignore IDE files by default #1063

camilamacedo86 opened this issue Nov 15, 2019 · 5 comments
Labels
good first issue help wanted kind/enhancement

Comments

@camilamacedo86
Copy link

@camilamacedo86 camilamacedo86 commented Nov 15, 2019

What would you like to be added:
Ignore IDE files by default in order to not face issues as:

$ kubectl kudo install ./first-operator
Error: failed to resolve package CRDs for operator: ./first-operator: while reading package from the file system: unexpected file when reading package from filesystem: first-operator/.idea/first-operator.iml
@alenkacz
Copy link
Contributor

@alenkacz alenkacz commented Nov 15, 2019

maybe we should ignore all hidden files/folders?
@porridge
Copy link
Contributor

@porridge porridge commented Nov 15, 2019

.kudoignore ? :-)
@porridge
Copy link
Contributor

@porridge porridge commented Nov 15, 2019

maybe we should ignore all hidden files/folders?

Note that conventions for file hiding depend on OS (I believe on Windows it is a special attribute, not based on filename). Something to keep in mind if we want consistent behaviour across OSes...
@ANeumann82
Copy link
Member

@ANeumann82 ANeumann82 commented Nov 26, 2019 •
edited

.kudoignore seems a lot more reasonable than to figure out the correct semantics for hidden files on all OSes. Additionally, i'd allow someone to ignore README.md or other docs.

If this is really important is another question, if the alternative is just to put the operator itself into a subdirectory.
@yankcrime
Copy link
Member

@yankcrime yankcrime commented Jan 9, 2020

What about parsing .gitignore, if present?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted kind/enhancement
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@alenkacz @yankcrime @porridge @ANeumann82 @camilamacedo86
You can’t perform that action at this time.