| Nov |
DEC |
Jan |
|
23 |
|
| 2021 |
2022 |
2023 |
About this capture
The Wayback Machine - http://web.archive.org/web/20221223071438/https://github.com/python/cpython/pull/99223
Skip to content
n
Sign up
●
Actions
Automate any workflow
Packages
Host and manage packages
Security
Find and fix vulnerabilities
Codespaces
Instant dev environments
Copilot
Write better code with AI
Code review
Manage code changes
Issues
Plan and track work
Discussions
Collaborate outside of code
●Explore
●
●
●
●
●
●For
●
●
●
●
●By Solution
●
●
●
●Case Studies
●
●
●
GitHub Sponsors
Fund open source developers
The ReadME Project
GitHub community articles
●Repositories
●
●
●
●
In this repository
All GitHub
↵
Jump to
↵
-
No suggested jump to results
{{ message }}
python
/
cpython
Public
●
Notifications
●
Fork
25.3k
Star
49.6k
●
Code
●
Issues
5k+
●
Pull requests
1.4k
●
Actions
●
Projects
27
●
Security
●
Insights
More
●
Code
●
Issues
●
Pull requests
●
Actions
●
Projects
●
Security
●
Insights
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
-
-
-
-
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
Sign in
to your account
Jump to bottom
Merged
ericsnowcurrently
merged 6 commits into
python:main
from
ericsnowcurrently:generated-objects-cleanup
Nov 8, 2022
Merged
ericsnowcurrently
merged 6 commits into
python:main
from
ericsnowcurrently:generated-objects-cleanup
Nov 8, 2022
Files changed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show hidden characters
Member
We do the following:
●move the generated _PyUnicode_InitStaticStrings() to its own file
●move the generated _PyStaticObjects_CheckRefcnt() to its own file
●include pycore_global_objects.h in extension modules instead of pycore_runtime_init.h
These changes help us avoid including things that aren't needed.
●Issue: Share global string identifiers in deepfreeze #90868
Sorry, something went wrong.
ericsnowcurrently
added
the
skip news
label
Nov 8, 2022
ericsnowcurrently
requested review from
a team,
1st1,
asvetlov and
gvanrossumascode owners
Nov 8, 2022
bedevere-bot
mentioned this pull request
Nov 8, 2022
Share global string identifiers in deepfreeze
#90868
Closed
bedevere-bot
added
the
awaiting core review
label
Nov 8, 2022
ericsnowcurrently
added 6commits
Nov 8, 2022
Do not include pycore_runtime_init.h in modules.
b3f0b39
Add pycore_unicodeobject_generated.h.
71e0e37
Ignore the generated files.
9997f6b
Generate pycore_unicodeobject_generated.h and use it.
739ebe9
Add pycore_global_objects_fini_generated.h.
c680298
Generate pycore_global_objects_fini_generated.h and use it.
aa76fcc
ericsnowcurrently
force-pushed
the
generated-objects-cleanup
branch
from
6e434d8
to
aa76fcc
Compare
Nov 8, 2022
ericsnowcurrently
removed request for
a team,
1st1,
asvetlov and
gvanrossum
Nov 8, 2022
ericsnowcurrently
merged commit 52f91c6
into
python:main
Nov 8, 2022
13 checks passed
ericsnowcurrently
deleted the
generated-objects-cleanup
branch
Nov 8, 2022
bedevere-bot
removed
the
awaiting core review
label
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No reviews
No one assigned
Labels
skip news
No milestone
Successfully merging this pull request may close these issues.
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Footer
© 2022 GitHub, Inc.
●Terms
●Privacy
●Security
●Status
●Docs
●Contact GitHub
●Pricing
●API
●Training
●Blog
●About
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.
You signed out in another tab or window. Reload to refresh your session.