chore(VRT Pipelines): remove unneeded variables from yml files #27040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 191245b:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 27c3cfe8a95bd26541c7c47ad2fd7fbc8ea332df (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1584 | 1550 | 5000 | |
| Button | mount | 1148 | 1125 | 5000 | |
| Field | mount | 2417 | 2387 | 5000 | |
| FluentProvider | mount | 1961 | 1917 | 5000 | |
| FluentProviderWithTheme | mount | 732 | 740 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 695 | 697 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 727 | 734 | 10 | |
| InfoButton | mount | 666 | 657 | 5000 | |
| MakeStyles | mount | 2227 | 2202 | 50000 | |
| Persona | mount | 3517 | 3435 | 5000 | |
| SpinButton | mount | 2842 | 2802 | 5000 |
fabricteam
reviewed
Mar 2, 2023
|
| Package & Exports | Size (minified/GZIP) |
|---|---|
| global-context createContext |
533 B341 B |
| global-context createContextSelector |
554 B348 B |
| priority-overflow createOverflowManager |
3.194 kB1.314 kB |
| react-accordion Accordion (including children components) |
85.876 kB26.019 kB |
| react-alert Alert |
90.221 kB22.094 kB |
| react-avatar Avatar |
51.192 kB14.043 kB |
| react-avatar AvatarGroup |
15.42 kB6.167 kB |
| react-avatar AvatarGroupItem |
67.414 kB18.551 kB |
| react-badge Badge |
23.113 kB7.069 kB |
| react-badge CounterBadge |
24.002 kB7.374 kB |
| react-badge PresenceBadge |
25.438 kB7.254 kB |
| react-button Button |
39.644 kB9.941 kB |
| react-button CompoundButton |
46.826 kB11.411 kB |
| react-button MenuButton |
44.327 kB11.265 kB |
| react-button SplitButton |
52.877 kB12.872 kB |
| react-button ToggleButton |
58.013 kB11.859 kB |
| react-card Card - All |
83.548 kB23.894 kB |
| react-card Card |
78.317 kB22.433 kB |
| react-card CardFooter |
9.045 kB3.806 kB |
| react-card CardHeader |
10.984 kB4.509 kB |
| react-card CardPreview |
9.852 kB4.159 kB |
| react-checkbox Checkbox |
33.091 kB10.319 kB |
| react-checkbox CheckboxField |
39.996 kB12.206 kB |
| react-combobox Combobox (including child components) |
85.509 kB27.437 kB |
| react-combobox ComboboxField |
81.926 kB27.213 kB |
| react-combobox Dropdown (including child components) |
84.196 kB27.191 kB |
| react-components react-components: Button, FluentProvider & webLightTheme |
67.061 kB18.105 kB |
| react-components react-components: Accordion, Button, FluentProvider, Image, Menu, Popover |
205.522 kB57.033 kB |
| react-components react-components: FluentProvider & webLightTheme |
37.891 kB12.039 kB |
| react-dialog Dialog (including children components) |
89.808 kB26.701 kB |
| react-divider Divider |
17.11 kB6.18 kB |
| react-field Field |
17.673 kB6.543 kB |
| react-image Image |
11.259 kB4.473 kB |
| react-infobutton InfoButton |
127.411 kB38.824 kB |
| react-input Input |
22.94 kB7.214 kB |
| react-input InputField |
32.819 kB10.111 kB |
| react-label Label |
9.822 kB4.066 kB |
| react-link Link |
12.306 kB5.073 kB |
| react-menu Menu (including children components) |
127.102 kB38.881 kB |
| react-menu Menu (including selectable components) |
130.171 kB39.399 kB |
| react-overflow hooks only |
11.214 kB4.271 kB |
| react-persona Persona |
58.207 kB15.986 kB |
| react-popover Popover |
114.483 kB35.249 kB |
| react-portal Portal |
11.377 kB4.179 kB |
| react-portal-compat PortalCompatProvider |
6.324 kB2.129 kB |
| react-positioning usePositioning |
23.791 kB8.73 kB |
| react-progress ProgressBar |
13.59 kB5.24 kB |
| react-progress ProgressField |
23.885 kB8.385 kB |
| react-provider FluentProvider |
19.958 kB6.838 kB |
| react-radio Radio |
32.676 kB10.616 kB |
| react-radio RadioGroup |
14.885 kB5.933 kB |
| react-radio RadioGroupField |
24.963 kB9.07 kB |
| react-select Select |
24.145 kB8.271 kB |
| react-select SelectField |
33.384 kB10.779 kB |
| react-slider Slider |
33.091 kB10.555 kB |
| react-slider SliderField |
42.922 kB13.465 kB |
| react-spinbutton SpinButton |
32.83 kB9.864 kB |
| react-spinbutton SpinButtonField |
41.766 kB12.254 kB |
| react-spinner Spinner |
20.62 kB6.682 kB |
| react-switch Switch |
28.225 kB8.755 kB |
| react-switch SwitchField |
35.01 kB10.655 kB |
| react-table DataGrid |
144.785 kB39.447 kB |
| react-table Table (Primitives only) |
43.776 kB12.063 kB |
| react-table Table as DataGrid |
134.4 kB34.514 kB |
| react-table Table (Selection only) |
82.316 kB20.576 kB |
| react-table Table (Sort only) |
81.637 kB20.386 kB |
| react-text Text - Default |
12.261 kB4.819 kB |
| react-text Text - Wrappers |
15.571 kB5.23 kB |
| react-textarea Textarea |
26.336 kB8.585 kB |
| react-textarea TextareaField |
36.537 kB11.504 kB |
| react-theme Single theme token import |
69 B89 B |
| react-theme Teams: all themes |
30.908 kB6.714 kB |
| react-theme Teams: Light theme |
17.776 kB5.141 kB |
| react-tooltip Tooltip |
46.328 kB16.212 kB |
| react-utilities SSRProvider |
180 B159 B |
Perf Analysis (
|
fabricteam
reviewed
Mar 2, 2023
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1372 | 1400 | 5000 | |
| Breadcrumb | mount | 3462 | 3396 | 1000 | |
| Checkbox | mount | 3058 | 3053 | 5000 | |
| CheckboxBase | mount | 2754 | 2723 | 5000 | |
| ChoiceGroup | mount | 5109 | 5173 | 5000 | |
| ComboBox | mount | 1474 | 1459 | 1000 | |
| CommandBar | mount | 11101 | 11110 | 1000 | |
| ContextualMenu | mount | 16053 | 15748 | 1000 | |
| DefaultButton | mount | 1605 | 1616 | 5000 | |
| DetailsRow | mount | 3970 | 4036 | 5000 | |
| DetailsRowFast | mount | 4034 | 4087 | 5000 | |
| DetailsRowNoStyles | mount | 3892 | 3865 | 5000 | |
| Dialog | mount | 3634 | 3640 | 1000 | |
| DocumentCardTitle | mount | 660 | 658 | 1000 | |
| Dropdown | mount | 3740 | 3749 | 5000 | |
| FocusTrapZone | mount | 2335 | 2356 | 5000 | |
| FocusZone | mount | 2298 | 2294 | 5000 | |
| GroupedList | mount | 59293 | 65425 | 2 | |
| GroupedList | virtual-rerender | 28069 | 28182 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 105574 | 105544 | 2 | |
| GroupedListV2 | mount | 640 | 655 | 2 | |
| GroupedListV2 | virtual-rerender | 622 | 646 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 659 | 651 | 2 | |
| IconButton | mount | 2220 | 2217 | 5000 | |
| Label | mount | 860 | 849 | 5000 | |
| Layer | mount | 5025 | 5015 | 5000 | |
| Link | mount | 953 | 977 | 5000 | |
| MenuButton | mount | 1928 | 1927 | 5000 | |
| MessageBar | mount | 2670 | 2749 | 5000 | |
| Nav | mount | 3827 | 3813 | 1000 | |
| OverflowSet | mount | 1570 | 1561 | 5000 | |
| Panel | mount | 2962 | 2937 | 1000 | |
| Persona | mount | 1532 | 1486 | 1000 | |
| Pivot | mount | 1908 | 1930 | 1000 | |
| PrimaryButton | mount | 1776 | 1800 | 5000 | |
| Rating | mount | 8085 | 8181 | 5000 | |
| SearchBox | mount | 1771 | 1783 | 5000 | |
| Shimmer | mount | 3276 | 3311 | 5000 | |
| Slider | mount | 2480 | 2433 | 5000 | |
| SpinButton | mount | 5414 | 5430 | 5000 | |
| Spinner | mount | 929 | 925 | 5000 | |
| SplitButton | mount | 3646 | 3570 | 5000 | |
| Stack | mount | 962 | 952 | 5000 | |
| StackWithIntrinsicChildren | mount | 2647 | 2644 | 5000 | |
| StackWithTextChildren | mount | 5495 | 5495 | 5000 | |
| SwatchColorPicker | mount | 11993 | 11992 | 5000 | |
| TagPicker | mount | 3015 | 3008 | 5000 | |
| TeachingBubble | mount | 95655 | 96249 | 5000 | |
| Text | mount | 925 | 915 | 5000 | |
| TextField | mount | 1831 | 1818 | 5000 | |
| ThemeProvider | mount | 1752 | 1770 | 5000 | |
| ThemeProvider | virtual-rerender | 1264 | 1243 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2515 | 2501 | 5000 | |
| Toggle | mount | 1316 | 1280 | 5000 | |
| buttonNative | mount | 636 | 636 | 5000 |
|
/azp run Fluent UI React - PR and CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ling1726
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Changes:
shouldBuildStorybookAddonandshouldBuildNorthstarvariables from .yml files as the changes in feat(scripts-storybook): unify workspace addon loading for dev and prod builds #27006 makes them unnecessary.Related Issue(s)