HAProxy Load Balancer's development branch (mirror of git.haproxy.org)
License
haproxy/haproxy
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
master
Could not load branches
Nothing to show
Could not load tags
Nothing to show
{{ refName }}
default
Name already in use
A tag already exists with the provided branch name. Many Git commands accept both tag and branch names, so creating this branch may cause unexpected behavior. Are you sure you want to create this branch?
Code
-
Clone
Use Git or checkout with SVN using the web URL.
Work fast with our official CLI. Learn more.
- Open with GitHub Desktop
- Download ZIP
Sign In Required
Please sign in to use Codespaces.
Launching GitHub Desktop
If nothing happens, download GitHub Desktop and try again.
Launching GitHub Desktop
If nothing happens, download GitHub Desktop and try again.
Launching Xcode
If nothing happens, download Xcode and try again.
Launching Visual Studio Code
Your codespace will open once ready.
There was a problem preparing your codespace, please try again.
Latest commit
Since 465a6c8 ("BUG/MEDIUM: applet: only set appctx->sedesc on successful allocation"), sedesc is attached to the appctx after the task is successfully allocated. If the task fails to allocate: current sedesc cleanup is performed on appctx->sedesc which still points to NULL so sedesc won't be freed. This is fine when sedesc is provided as argument (!=NULL), but leads to memory leaks if sedesc is allocated locally. It was shown in GH #2086 that if sedesc != NULL when passed as argument, it shouldn't be freed on error paths. This is what 465a6c8 was trying to address. In an attempt to fix both issues at once, we do as Christopher suggested: that is moving sedesc allocation attempt at the end of the function, so that we don't have to free it in case of error, thus removing the ambiguity. (We won't risk freeing a sedesc that does not belong to us) If we fail to allocate sedesc, then the task that was previously created locally is simply destroyed. This needs to be backported to 2.6 with 465a6c8 ("BUG/MEDIUM: applet: only set appctx->sedesc on successful allocation") [Copy pasting the original backport note from Willy: In 2.6 the function is slightly different and called appctx_new(), though the issue is exactly the same.]
821581c
Git stats
Files
Permalink
Failed to load latest commit information.
Type
Name
Latest commit message
Commit time
The HAProxy documentation has been split into a number of different files for ease of use. Please refer to the following files depending on what you're looking for : - INSTALL for instructions on how to build and install HAProxy - BRANCHES to understand the project's life cycle and what version to use - LICENSE for the project's license - CONTRIBUTING for the process to follow to submit contributions The more detailed documentation is located into the doc/ directory : - doc/intro.txt for a quick introduction on HAProxy - doc/configuration.txt for the configuration's reference manual - doc/lua.txt for the Lua's reference manual - doc/SPOE.txt for how to use the SPOE engine - doc/network-namespaces.txt for how to use network namespaces under Linux - doc/management.txt for the management guide - doc/regression-testing.txt for how to use the regression testing suite - doc/peers.txt for the peers protocol reference - doc/coding-style.txt for how to adopt HAProxy's coding style - doc/internals for developer-specific documentation (not all up to date)
About
HAProxy Load Balancer's development branch (mirror of git.haproxy.org)
Topics
Resources
License
Stars
Watchers
Forks
Packages 0
No packages published

