Contents

Wikipedia:Bots/Requests for approval/PrimeBOT 39: Difference between revisions

Latest revision as of 10:51, 22 September 2023

Operator: Primefac (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 12:48, Thursday, May 11, 2023 (UTC)

Function overview: Convert template use following update

Automatic, Supervised, or Manual: Automatic

Programming language(s): AWB

Source code available: WP:AWB

Links to relevant discussions (where appropriate): Wikipedia talk:WikiProject Templates § Request for a template

Edit period(s): OTR

Estimated number of pages affected:

Namespace(s): 783

Exclusion compliant (Yes/No): Yes

Function details: {{Wikisource author}} recently was updated to allow for a |lang= parameter to link directly to non-English versions of wikisource for an author. A similar template, {{Wikisourcelang}}, links to a generic search on said language wiki for said author. This task will change {{Wikisourcelang|<lang>|otherstuff}} into a {{Wikisource author|lang=<lang>|otherstuff}} call.

• {{BAG assistance needed}} valid request not attended by any BAG members for almost two months. —usernamekiran (talk) 23:02, 29 June 2023 (UTC)[reply]
• Approved for trial (25 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete.

This seems pretty straightforward. Let's go to trial.

Headbomb {t · c · p · b} 17:38, 2 July 2023 (UTC)[reply]

Trial complete. Edits. As a note, I did not run genfixes just to make the proposed change more obvious, but if this task does proceed I will be running genfixes alongside them.

Piotrus, I think this request is a little more convoluted than initially requested. Languages such as de do not use an "author" prefix (see e.g. Adolph Friedrich Johann Riedel and his corresponding page on de Wikisource), but I can't figure out which languages it holds to. I am not necessarily seeing a specific pattern between what languages do and do not. My thoughts are of two possibilities - run this task only for languages where the proposed change has the intended effect, or just scrap this BRFA and do these changes manually. Primefac (talk) 12:52, 4 July 2023 (UTC)[reply]

@Primefac I think we can run it for some languages that we can determine now, it shouldn't be that hard as long as it is consistent for each language (ex. German never uses, Polish always uses it, etc.). We could create a list for all languages that wikisource exists on, or just run it for now for some editions that are the biggest (ex. the ones with interwikis here). I did some checks and it seems it's pretty consisten - just a wikisource naming convention. Note that depending on the language, the "author" prefix is different - Polish is "autor". Swedish is "Författare", etc. In the end, what we need to fix is not the outgoing links but the text on our side. Consider this case, similar to the German one you quote, where we improved the language or our template but messed the link: before, diff, after. Since the links work, can we just figure out the way to change the wording in the template but retain the same link as before? The older template was able to do it, somehow, seems we are introducing a new error somehow? _{Piotr Konieczny aka Prokonsul Piotrus| reply here} 04:48, 5 July 2023 (UTC)[reply]

If you wouldn't mind making a list of which languages use the Author (in whatever language) prefix, I can hard-code their use into the template so that there isn't any issue.

This wasn't a problem before because {{wikisource author}} only linked to to the English version so no translation or odd coding was necessary. As mentioned in the original discussion, {{wikisource lang}} just links to a general search (which does sometimes turn up the author page directly) and thus does not require the "Author:" prefix. Primefac (talk) 08:06, 5 July 2023 (UTC)[reply]

 On hold. Just for now, while we deal with actual template issues. Primefac (talk) 08:31, 5 July 2023 (UTC)[reply]

@Primefac See talk, is this helpful? Those are most larger Wiki source projects, should be enough to get most of our stuff sorted out. We can take a look at what, if anything, is left after dealing with those languages? _{Piotr Konieczny aka Prokonsul Piotrus| reply here} 07:06, 7 July 2023 (UTC)[reply]

Should do, thanks for that. Going to keep this on hold for a bit longer, there's a TFD for merging all of these together and I might be able to enact these proposed changes during the merge process. Primefac (talk) 08:13, 7 July 2023 (UTC)[reply]

@Primefac Just checking the status of this? _{Piotr Konieczny aka Prokonsul Piotrus| reply here} 09:54, 22 September 2023 (UTC)[reply]

Somewhat stalled, been rather busy myself and it doesn't look like anyone has started work on the template merger. I think I might have cleared my on-wiki plate somewhat (touch wood) so I'll see about prioritising the merger. Primefac (talk) 10:51, 22 September 2023 (UTC)[reply]