J u m p t o c o n t e n t
M a i n m e n u
M a i n m e n u
N a v i g a t i o n
● M a i n p a g e
● C o n t e n t s
● C u r r e n t e v e n t s
● R a n d o m a r t i c l e
● A b o u t W i k i p e d i a
● C o n t a c t u s
● D o n a t e
C o n t r i b u t e
● H e l p
● L e a r n t o e d i t
● C o m m u n i t y p o r t a l
● R e c e n t c h a n g e s
● U p l o a d f i l e
S e a r c h
Search
A p p e a r a n c e
● C r e a t e a c c o u n t
● L o g i n
P e r s o n a l t o o l s
● C r e a t e a c c o u n t
● L o g i n
P a g e s f o r l o g g e d o u t e d i t o r s l e a r n m o r e
● C o n t r i b u t i o n s
● T a l k
( T o p )
1
D a n n y S 7 1 2 b o t 1 5
T o g g l e D a n n y S 7 1 2 b o t 1 5 s u b s e c t i o n
1 . 1
D i s c u s s i o n
T o g g l e t h e t a b l e o f c o n t e n t s
W i k i p e d i a : B o t s / R e q u e s t s f o r a p p r o v a l / D a n n y S 7 1 2 b o t 1 5
A d d l a n g u a g e s
A d d l i n k s
● P r o j e c t p a g e
● T a l k
E n g l i s h
● R e a d
● E d i t
● V i e w h i s t o r y
T o o l s
T o o l s
A c t i o n s
● R e a d
● E d i t
● V i e w h i s t o r y
G e n e r a l
● W h a t l i n k s h e r e
● R e l a t e d c h a n g e s
● U p l o a d f i l e
● S p e c i a l p a g e s
● P e r m a n e n t l i n k
● P a g e i n f o r m a t i o n
● G e t s h o r t e n e d U R L
● D o w n l o a d Q R c o d e
P r i n t / e x p o r t
● D o w n l o a d a s P D F
● P r i n t a b l e v e r s i o n
A p p e a r a n c e
F r o m W i k i p e d i a , t h e f r e e e n c y c l o p e d i a
< W i k i p e d i a : B o t s | R e q u e s t s f o r a p p r o v a l
Approved BRFAs
talk
contribs
count
SUL
logs
page moves
block log
rights log
flag )
Operator: DannyS712 (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search )
Time filed: 08:34, Saturday, March 16, 2019 (UTC )
Automatic, Supervised, or Manual: automatic
Programming language (s ): JavaScript
Source code available:
Function overview: adding {{Germany district OSM map }} to the 'map' parameter of {{Infobox District DE }}, where QXXXX is the Wikidata ID of the German state the district belongs to
Links to relevant discussions (where appropriate): WP:BOTREQ#OSM location map for German districts
Edit period(s ): One time run
Estimated number of pages affected: <400
Exclusion compliant (Yes/No) : No
Already has a bot flag (Yes/No) : Yes
Function details: Using the API, retrieve the wikidata wikibase_item
for a page, and then add the corresponding parameter to {{ Infobox District DE }} .
Discussion[ edit ]
Approved for trial (50 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. @DannyS712 : I thought I'd done this last night, but apparently not. Anyways, approved for trial. As usual, please post the diffs here when done and take all the time you need. --The SandDoctor Talk 18:03, 17 March 2019 (UTC) [ reply ]
@TheSandDoctor : Trial complete. see the 49 edits made at [1 ] . @Underlying lk : I didn't see any errors, but I also am not as familiar with the template and its use as you are. Can you take a look? --DannyS712 (talk ) 00:28, 24 March 2019 (UTC) [ reply ]
parent_subdivision
should be the QID of the state, for instance Lower Saxony (Q1197) for Hildesheim (district) and all the other districts in Niedersachsen; see this diff .--eh bien mon prince (talk ) 00:36, 24 March 2019 (UTC) [ reply ]
@Underlying lk : hang on, so its not the QXXXX of the page itself? Then how do I find what page it is for? I'm rolling back the edits, since they were all wrong then. --DannyS712 (talk ) 00:40, 24 March 2019 (UTC) [ reply ]
@DannyS712 : This query can be used for that.--eh bien mon prince (talk ) 14:08, 24 March 2019 (UTC) [ reply ]
@Underlying lk : so just to confirm, the actual Q value to be added is the one listed under "located_in_the_administrative_territorial_entity", for each page labeled "rural_district_of_Germany". Thanks, --DannyS712 (talk ) 18:53, 24 March 2019 (UTC) [ reply ]
@DannyS712 : Correct.--eh bien mon prince (talk ) 18:58, 24 March 2019 (UTC) [ reply ]
@Underlying lk : So I should use User:DannyS712 test/infobox3.json instead of User:DannyS712 test/infobox2.json for the source? --DannyS712 (talk ) 19:15, 24 March 2019 (UTC) [ reply ]
@DannyS712 : seems right to me.--eh bien mon prince (talk ) 19:36, 24 March 2019 (UTC) [ reply ]
@Underlying lk : in that case, @TheSandDoctor : would you be willing to approve an extended trial? I'll check the first bunch of edits the bot makes to ensure that it links to a correct map. Thanks, --DannyS712 (talk ) 19:38, 24 March 2019 (UTC) [ reply ]
Approved for extended trial (25 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. @DannyS712 : --The SandDoctor Talk 03:21, 25 March 2019 (UTC) [ reply ]
@TheSandDoctor : shouldn't this be {{ BotExtendedTrial }} ? --DannyS712 (talk ) 03:41, 25 March 2019 (UTC) [ reply ]
@DannyS712 : You're right, it was a case of "thought I did one thing, but did another." Fixed --The SandDoctor Talk 05:14, 25 March 2019 (UTC) [ reply ]
@TheSandDoctor : Trial complete. 25 edits made [2 ] . Code is at User:DannyS712 test/Map bot.js , actual list of pages to edit is at User:DannyS712 test/infobox4.json (infobox3 but removing pages that don't exist on enwiki). So of those listed won't be edited because they have to map parameter to replace. @Underlying lk : I looked, and don't see any errors. --DannyS712 (talk ) 00:30, 26 March 2019 (UTC) [ reply ]
Edits look fine to me.--eh bien mon prince (talk ) 13:24, 26 March 2019 (UTC) [ reply ]
I checked a few more, and all the maps seem to be working. --DannyS712 (talk ) 17:03, 28 March 2019 (UTC) [ reply ]
Since there was no error on this, and the (limited) response seems positive , and no one objected after about 2-3 weeks, Approved. . Headbomb {t · c · p · b } 03:36, 3 April 2019 (UTC) [ reply ]
The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA .
R e t r i e v e d f r o m " https://en.wikipedia.org/w/index.php?title=Wikipedia:Bots/Requests_for_approval/DannyS712_bot_15&oldid=890721777 "
C a t e g o r y :
● A p p r o v e d W i k i p e d i a b o t r e q u e s t s f o r a p p r o v a l
● T h i s p a g e w a s l a s t e d i t e d o n 3 A p r i l 2 0 1 9 , a t 0 3 : 3 6 ( U T C ) .
● T e x t i s a v a i l a b l e u n d e r t h e C r e a t i v e C o m m o n s A t t r i b u t i o n - S h a r e A l i k e L i c e n s e 4 . 0 ;
a d d i t i o n a l t e r m s m a y a p p l y . B y u s i n g t h i s s i t e , y o u a g r e e t o t h e T e r m s o f U s e a n d P r i v a c y P o l i c y . W i k i p e d i a ® i s a r e g i s t e r e d t r a d e m a r k o f t h e W i k i m e d i a F o u n d a t i o n , I n c . , a n o n - p r o f i t o r g a n i z a t i o n .
● P r i v a c y p o l i c y
● A b o u t W i k i p e d i a
● D i s c l a i m e r s
● C o n t a c t W i k i p e d i a
● C o d e o f C o n d u c t
● D e v e l o p e r s
● S t a t i s t i c s
● C o o k i e s t a t e m e n t
● M o b i l e v i e w